Skip to content

[fix](be)fix bug of converting outer join probe block to nullable #25492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 17, 2023
Merged

[fix](be)fix bug of converting outer join probe block to nullable #25492

yiguolei merged 1 commit into from
Oct 17, 2023

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Oct 16, 2023 •
edited
Loading

Proposed changes

_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999
Copy link
Contributor Author

starocean999 commented Oct 16, 2023

run buildall

@starocean999 starocean999 changed the title [fix](be)confix bug of converting outer join probe block to nullable [fix](be)fix bug of converting outer join probe block to nullable Oct 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Oct 16, 2023

TeamCity be ut coverage result:
Function Coverage: 36.76% (8218/22357)
Line Coverage: 28.85% (65873/228336)
Region Coverage: 27.57% (34199/124048)
Branch Coverage: 24.25% (17398/71758)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2606a57176f1267648bb62047b32fa848b6a346c_2606a57176f1267648bb62047b32fa848b6a346c/report/index.html

@doris-robot
Copy link

doris-robot commented Oct 16, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.54 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17162284321 Bytes

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

PR approved by anyone and no changes requested.

yiguolei
yiguolei approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit ef7d8aa into apache:master Oct 17, 2023
@wm1581066 wm1581066 added the usercase Important user case type label label Oct 17, 2023
@zhangstar333 zhangstar333 mentioned this pull request Oct 19, 2023
Merged
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
@starocean999
[fix](be)confix bug of converting outer join probe block to nullable (a…
1090e31 
…pache#25492)

_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate
@xiaokang xiaokang mentioned this pull request Dec 4, 2023
Closed
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@starocean999
[fix](be)confix bug of converting outer join probe block to nullable (a…
8030bad 
…pache#25492)

_do_evaluate will add temp result column into original table block, so in order to only convert correct columns to be nullable, need call convert_block_to_null before _do_evaluate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged merge_conflict pick_pipelinex reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@starocean999 @doris-robot @BiteTheDDDDt @yiguolei @xiaokang @wm1581066