Skip to content

[coverage](pipeline) Remove unless code and add call method for coverage #25552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BiteTheDDDDt merged 1 commit into from
Oct 23, 2023
Merged

[coverage](pipeline) Remove unless code and add call method for coverage #25552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions be/src/pipeline/exec/exchange_sink_operator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ class ExchangeSinkOperator final : public DataSinkOperator<ExchangeSinkOperatorB

Status close(RuntimeState* state) override;

RuntimeState* state() { return _state; }

private:
std::unique_ptr<ExchangeSinkBuffer<vectorized::VDataStreamSender>> _sink_buffer;
int _dest_node_id = -1;
Expand Down
2 changes: 1 addition & 1 deletion be/src/pipeline/exec/multi_cast_data_stream_sink.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class MultiCastDataStreamSinkOperator final
MultiCastDataStreamSinkOperator(OperatorBuilderBase* operator_builder, DataSink* sink)
: DataSinkOperator(operator_builder, sink) {}

bool can_write() override { return true; }
bool can_write() override { return _sink->can_write(); }
};

class MultiCastDataStreamSinkOperatorX;
Expand Down
4 changes: 1 addition & 3 deletions be/src/util/proto_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ Status request_embed_attachment_contain_block(Params* brpc_request, Closure* clo
return st;
}

inline bool enable_http_send_block(
const PTransmitDataParams& request,
bool transfer_large_data_by_brpc = config::transfer_large_data_by_brpc) {
inline bool enable_http_send_block(const PTransmitDataParams& request) {
if (!config::transfer_large_data_by_brpc) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/sink/vdata_stream_sender.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ Status Channel<Parent>::send_remote_block(PBlock* block, bool eos, Status exec_s

{
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER(ExecEnv::GetInstance()->orphan_mem_tracker());
if (enable_http_send_block(_brpc_request, config::transfer_large_data_by_brpc)) {
if (enable_http_send_block(_brpc_request)) {
RETURN_IF_ERROR(transmit_block_http(_state->exec_env(), _closure, _brpc_request,
_brpc_dest_addr));
} else {
Expand Down