Skip to content

Improve cardinality, avgRowSize, numNodes stat info in OlapScanNode #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 2 commits into from
Nov 7, 2018
Merged

Improve cardinality, avgRowSize, numNodes stat info in OlapScanNode #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32986c9
Improve cardinality, avgRowSize, numNodes stat info in OlapScanNode
kangkaisen Jul 20, 2018
c2af9f4
Compute cardinality only for one replica
kangkaisen Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions fe/src/main/java/org/apache/doris/planner/OlapScanNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,12 @@ public class OlapScanNode extends ScanNode {
private long totalTabletsNum = 0;
private long selectedIndexId = -1;
private int selectedPartitionNum = 0;
private long totalBytes = 0;

boolean isFinalized = false;

private HashSet<Long> scanBackendIds = new HashSet<>();

/**
* Constructs node to scan given data files of table 'tbl'.
*/
Expand Down Expand Up @@ -143,9 +146,22 @@ public void finalize(Analyzer analyzer) throws UserException {
throw new UserException(e.getMessage());
}

computeStats(analyzer);
isFinalized = true;
}

@Override
public void computeStats(Analyzer analyzer) {
if (cardinality > 0) {
avgRowSize = totalBytes / (float) cardinality;
if (hasLimit()) {
cardinality = Math.min(cardinality, limit);
}
numNodes = scanBackendIds.size();
}
}


// private void analyzeVectorizedConjuncts(Analyzer analyzer) throws InternalException {
// for (SlotDescriptor slot : desc.getSlots()) {
// for (Expr conjunct : conjuncts) {
Expand Down Expand Up @@ -434,6 +450,7 @@ private void addScanRangeLocations(Partition partition,

Collections.shuffle(replicas);
boolean tabletIsNull = true;
boolean collectedStat = false;
for (Replica replica : replicas) {
Backend backend = Catalog.getCurrentSystemInfo().getBackend(replica.getBackendId());
if (backend == null) {
Expand All @@ -447,6 +464,14 @@ private void addScanRangeLocations(Partition partition,
scanRangeLocations.addToLocations(scanRangeLocation);
paloRange.addToHosts(new TNetworkAddress(ip, port));
tabletIsNull = false;

//for CBO
if (!collectedStat && replica.getRowCount() != -1) {
cardinality += replica.getRowCount();
totalBytes += replica.getDataSize();
collectedStat = true;
}
scanBackendIds.add(backend.getId());
}
if (tabletIsNull) {
throw new UserException(tabletId + "have no alive replicas");
Expand Down Expand Up @@ -599,6 +624,18 @@ protected String getNodeExplainString(String prefix, TExplainLevel detailLevel)
"buckets=%s/%s", selectedTabletsNum, totalTabletsNum));
output.append("\n");

output.append(prefix).append(String.format(
"cardinality=%s", cardinality));
output.append("\n");

output.append(prefix).append(String.format(
"avgRowSize=%s", avgRowSize));
output.append("\n");

output.append(prefix).append(String.format(
"numNodes=%s", numNodes));
output.append("\n");

return output.toString();
}

Expand Down