Skip to content

[bug](cherry-pick) fix bug of converting outer join probe block to nullable #25626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 3 commits into from
Oct 19, 2023
Merged

[bug](cherry-pick) fix bug of converting outer join probe block to nullable #25626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a021634
[refactor](join) improve join node output when build table rows is 0 …
zhangstar333 Sep 4, 2023
b8e2950
[Enhancement](filter) support only min/max runtime filter in BE (#25290)
zhangstar333 Oct 12, 2023
38b6d16
[bug](cherry-pick) fix bug of converting outer join probe block to nu…
zhangstar333 Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions be/src/vec/exec/join/vhash_join_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,11 +725,12 @@ Status HashJoinNode::push(RuntimeState* /*state*/, vectorized::Block* input_bloc
_probe_columns.resize(probe_expr_ctxs_sz);

std::vector<int> res_col_ids(probe_expr_ctxs_sz);
RETURN_IF_ERROR(
_do_evaluate(*input_block, _probe_expr_ctxs, *_probe_expr_call_timer, res_col_ids));
if (_join_op == TJoinOp::RIGHT_OUTER_JOIN || _join_op == TJoinOp::FULL_OUTER_JOIN) {
_probe_column_convert_to_null = _convert_block_to_null(*input_block);
}
RETURN_IF_ERROR(
_do_evaluate(*input_block, _probe_expr_ctxs, *_probe_expr_call_timer, res_col_ids));

// TODO: Now we are not sure whether a column is nullable only by ExecNode's `row_desc`
// so we have to initialize this flag by the first probe block.
if (!_has_set_need_null_map_for_probe) {
Expand Down