Skip to content

Conversation

@zhannngchen
Copy link
Contributor

@zhannngchen zhannngchen commented Oct 19, 2023

Proposed changes

Issue Number: close #xxx

cases in unique_with_mow_p2 should use sf100 dataset, rather than sf0.1 dataset
sf100 dataset have 10 data files for lineorder table, which is not easy to load through stream load, so I use s3 load instead.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@dataroaring
Copy link
Contributor

run buildall

@zhannngchen zhannngchen changed the title [fix](regression-test) use correct dataset for unique_with_mow_p2 [WIP][fix](regression-test) use correct dataset for unique_with_mow_p2 Oct 20, 2023
@zhannngchen zhannngchen marked this pull request as draft October 20, 2023 14:12
@zhannngchen zhannngchen force-pushed the fix_case_unique_with_mow_p2 branch from df565f1 to d734cef Compare October 23, 2023 06:44
@zhannngchen zhannngchen force-pushed the fix_case_unique_with_mow_p2 branch from bde9fc5 to f960c86 Compare October 24, 2023 05:54
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the fix_case_unique_with_mow_p2 branch from 342ad75 to f960c86 Compare October 24, 2023 08:22
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@zhannngchen zhannngchen force-pushed the fix_case_unique_with_mow_p2 branch from 1baf769 to df6b32c Compare October 25, 2023 12:26
@zhannngchen zhannngchen marked this pull request as ready for review October 26, 2023 03:01
@zhannngchen zhannngchen changed the title [WIP][fix](regression-test) use correct dataset for unique_with_mow_p2 [fix](regression-test) use correct dataset for unique_with_mow_p2 Oct 26, 2023
@zhannngchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants