[fix](trash core) fix get trash directory size core (#25428) #25829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
yujun777
changed the title
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Oct 28, 2023
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick: #25428
When multithreads access one directory, one thread create or delete a subdirectory, the other thread use directory_iterator may raise bad file discriptor error. See example. But I can not reproduce this.
The sweep thread use directory_iterator to calculate the trash directory size. While the gc thread will move new trash tablet into this trash directory. Sometimes stopping be will raise bad file discriptor when calcuating the trash directory size. We take a lot effect to find out the reason, but still unknown. So we make a code defence and ignore the get trash directory size filesystem error.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...