[fix](info_db) do not fetch external catalog's info in information_schema #25844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
AshinGau
approved these changes
Oct 25, 2023
Member
|
LGTM |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Jibing-Li
approved these changes
Oct 25, 2023
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Oct 28, 2023
…hema (apache#25844) There is FE config `infodb_support_ext_catalog`, the default is false. Which means that the tables in `information_schema` database will not return info of external catalog. Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests), querying infomation_schema db will take a long time and may causing rpc timeout. And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode. So to avoid this issue(not fix yet), this PR mainly changes: if `infodb_support_ext_catalog` is false, 1. query info of external catalog in information_schema db is not allowed, such as show database like "external_catalog"; show tables like "xxx" 2. select * from information_schema.tbl will not contains external catalogs' info 3. For external p0 regression test pipeline, set `infodb_support_ext_catalog` to true to run the tests related to external catalog
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Oct 31, 2023
…hema (apache#25844) There is FE config `infodb_support_ext_catalog`, the default is false. Which means that the tables in `information_schema` database will not return info of external catalog. Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests), querying infomation_schema db will take a long time and may causing rpc timeout. And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode. So to avoid this issue(not fix yet), this PR mainly changes: if `infodb_support_ext_catalog` is false, 1. query info of external catalog in information_schema db is not allowed, such as show database like "external_catalog"; show tables like "xxx" 2. select * from information_schema.tbl will not contains external catalogs' info 3. For external p0 regression test pipeline, set `infodb_support_ext_catalog` to true to run the tests related to external catalog
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Nov 1, 2023
…hema (apache#25844) There is FE config `infodb_support_ext_catalog`, the default is false. Which means that the tables in `information_schema` database will not return info of external catalog. Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests), querying infomation_schema db will take a long time and may causing rpc timeout. And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode. So to avoid this issue(not fix yet), this PR mainly changes: if `infodb_support_ext_catalog` is false, 1. query info of external catalog in information_schema db is not allowed, such as show database like "external_catalog"; show tables like "xxx" 2. select * from information_schema.tbl will not contains external catalogs' info 3. For external p0 regression test pipeline, set `infodb_support_ext_catalog` to true to run the tests related to external catalog
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Dec 4, 2023
…hema (apache#25844) There is FE config `infodb_support_ext_catalog`, the default is false. Which means that the tables in `information_schema` database will not return info of external catalog. Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests), querying infomation_schema db will take a long time and may causing rpc timeout. And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode. So to avoid this issue(not fix yet), this PR mainly changes: if `infodb_support_ext_catalog` is false, 1. query info of external catalog in information_schema db is not allowed, such as show database like "external_catalog"; show tables like "xxx" 2. select * from information_schema.tbl will not contains external catalogs' info 3. For external p0 regression test pipeline, set `infodb_support_ext_catalog` to true to run the tests related to external catalog
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…hema (apache#25844) There is FE config `infodb_support_ext_catalog`, the default is false. Which means that the tables in `information_schema` database will not return info of external catalog. Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests), querying infomation_schema db will take a long time and may causing rpc timeout. And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode. So to avoid this issue(not fix yet), this PR mainly changes: if `infodb_support_ext_catalog` is false, 1. query info of external catalog in information_schema db is not allowed, such as show database like "external_catalog"; show tables like "xxx" 2. select * from information_schema.tbl will not contains external catalogs' info 3. For external p0 regression test pipeline, set `infodb_support_ext_catalog` to true to run the tests related to external catalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is FE config
infodb_support_ext_catalog, the default is false.Which means that the tables in
information_schemadatabase will not return info of external catalog.Because if there are too many external catalogs in Doris with lots of db/tbl (like running p0 regression tests),
querying infomation_schema db will take a long time and may causing rpc timeout.
And there is an unresolved issue that if thrift rpc timeout, the BE may be crashed in ASAN mode.
So to avoid this issue(not fix yet), this PR mainly changes:
if
infodb_support_ext_catalogis false,query info of external catalog in information_schema db is not allowed, such as
show database like "external_catalog";
show tables like "xxx"
select * from information_schema.tbl will not contains external catalogs' info
For external p0 regression test pipeline, set
infodb_support_ext_catalogto true to run the tests related to external catalogFurther comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...