Skip to content

Conversation

@zhangguoqiang666
Copy link
Contributor

Proposed changes

docker hive s3 file address is determined based on the configuration custom_settings.env

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangguoqiang666
Copy link
Contributor Author

run buildall

@zhangguoqiang666
Copy link
Contributor Author

run buildall

morningman
morningman previously approved these changes Oct 25, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhangguoqiang666
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 25, 2023
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit e7a3cb0 into apache:master Oct 26, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

xiaokang pushed a commit that referenced this pull request Oct 26, 2023
…on the configuration (#25905)

docker hive s3 file address is determined based on the configuration custom_settings.env
dutyu pushed a commit to dutyu/doris that referenced this pull request Oct 28, 2023
…on the configuration (apache#25905)

docker hive s3 file address is determined based on the configuration custom_settings.env
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
…on the configuration (apache#25905)

docker hive s3 file address is determined based on the configuration custom_settings.env
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
…on the configuration (apache#25905)

docker hive s3 file address is determined based on the configuration custom_settings.env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants