Skip to content

[fix](Nereids) should not put bound expr into unbound group by list #25938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Oct 26, 2023
Merged

[fix](Nereids) should not put bound expr into unbound group by list #25938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindExpression.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,13 +273,17 @@ protected boolean condition(Rule rule, Plan plan) {
group_by_key is bound on t1.a
*/
duplicatedSlotNames.forEach(childOutputsToExpr::remove);
output.stream()
.filter(ne -> ne instanceof Alias)
.map(Alias.class::cast)
// agg function cannot be bound with group_by_key
.filter(alias -> !alias.child()
.anyMatch(expr -> expr instanceof AggregateFunction))
.forEach(alias -> childOutputsToExpr.putIfAbsent(alias.getName(), alias.child()));
for (int i = 0; i < output.size(); i++) {
if (!(output.get(i) instanceof Alias)) {
continue;
}
Alias alias = (Alias) output.get(i);
if (alias.child().anyMatch(expr -> expr instanceof AggregateFunction)) {
continue;
}
// NOTICE: must use unbound expressions, because we will bind them in binding group by expr.
childOutputsToExpr.putIfAbsent(alias.getName(), agg.getOutputExpressions().get(i).child(0));
}

List<Expression> replacedGroupBy = agg.getGroupByExpressions().stream()
.map(groupBy -> {
Expand Down
6 changes: 5 additions & 1 deletion regression-test/suites/nereids_syntax_p0/analyze_agg.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ suite("analyze_agg") {
d VARCHAR(30),
e VARCHAR(32),
a VARCHAR(32),
f VARCHAR(32)
f VARCHAR(32),
g DECIMAL(9, 3)
)ENGINE = OLAP
UNIQUE KEY(id)
DISTRIBUTED BY HASH(id) BUCKETS 30
Expand Down Expand Up @@ -73,4 +74,7 @@ suite("analyze_agg") {
sql "select count(distinct t2.b), variance(distinct t2.c) from t2"
exception "variance(DISTINCT c#2) can't support multi distinct."
}

// should not bind g /g in group by again, otherwise will throw exception
sql "select g / g as nu, sum(c) from t2 group by nu"
}