[Performance](Nereids): optimize GroupExpressionMatching #26084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
force-pushed
the
groupexpression_matching
branch
from
4e51af6 to
bc7f2a0
Compare
Member
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
jackwener
force-pushed
the
groupexpression_matching
branch
from
bc7f2a0 to
17b47a1
Compare
Member
Author
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
keanji-x
reviewed
Oct 30, 2023
Comment on lines
+48
to
+53
| // Jackwener: We don't need to match physical expressions. | ||
| // for (GroupExpression groupExpression : group.getPhysicalExpressions()) { | ||
| // for (Plan plan : new GroupExpressionMatching(pattern, groupExpression)) { | ||
| // matchingPlans.add(plan); | ||
| // } | ||
| // } |
starocean999
approved these changes
Oct 30, 2023
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
keanji-x
approved these changes
Oct 30, 2023
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Oct 31, 2023
…che#26084)" This reverts commit 0d956e9.
morrySnow
added a commit
that referenced
this pull request
Nov 1, 2023
…26164) 1. FE could not compile because below error. Intro by PR #25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - #25951 > - #26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR #25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (#26084)" > This reverts commit 0d956e9.
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Nov 4, 2023
dutyu
pushed a commit
to dutyu/doris
that referenced
this pull request
Nov 4, 2023
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Nov 13, 2023
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Nov 13, 2023
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
XuJianxu
pushed a commit
to XuJianxu/doris
that referenced
this pull request
Dec 14, 2023
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...