[Improve](map) support map cast with map literal and implicate nested scala cast #26126
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !select -- | ||
| 1 {"aa":1, "b":2, "1234567":77} | ||
| 2 {"b":12, "123":7777} | ||
|
|
||
| -- !select -- | ||
| {} | ||
|
|
||
| -- !select -- | ||
| {} | ||
|
|
||
| -- !sql1 -- | ||
| \N | ||
|
|
||
| -- !sql2 -- | ||
| {"":NULL} | ||
|
|
||
| -- !sql3 -- | ||
| {"1":2} | ||
|
|
||
| -- !sql4 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":7777} | ||
|
|
||
| -- !sql5 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":7777} | ||
|
|
||
| -- !sql6 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":97} | ||
|
|
||
| -- !sql7 -- | ||
| {"aa":"1", "b":"2", "1234567":"77"} | ||
| {"b":"12", "123":"7777"} | ||
|
|
||
| -- !sql8 -- | ||
| {NULL:"1", NULL:"2", 1234567:"77"} | ||
| {NULL:"12", 123:"7777"} | ||
|
|
||
| -- !sql9 -- | ||
| {NULL:1, NULL:2, 1234567:77} | ||
| {NULL:12, 123:7777} | ||
|
|
||
| -- !sql10 -- | ||
| {NULL:NULL, NULL:NULL, 1234567:NULL} | ||
| {NULL:NULL, 123:NULL} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !select -- | ||
| 1 {"aa":1, "b":2, "1234567":77} | ||
| 2 {"b":12, "123":7777} | ||
|
|
||
| -- !select -- | ||
| {} | ||
|
|
||
| -- !select -- | ||
| {} | ||
|
|
||
| -- !sql1 -- | ||
| \N | ||
|
|
||
| -- !sql2 -- | ||
| {"":NULL} | ||
|
|
||
| -- !sql3 -- | ||
| {"1":2} | ||
|
|
||
| -- !sql4 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":7777} | ||
|
|
||
| -- !sql5 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":7777} | ||
|
|
||
| -- !sql6 -- | ||
| {"aa":1, "b":2, "1234567":77} | ||
| {"b":12, "123":97} | ||
|
|
||
| -- !sql7 -- | ||
| {"aa":"1", "b":"2", "1234567":"77"} | ||
| {"b":"12", "123":"7777"} | ||
|
|
||
| -- !sql8 -- | ||
| {NULL:"1", NULL:"2", 1234567:"77"} | ||
| {NULL:"12", 123:"7777"} | ||
|
|
||
| -- !sql9 -- | ||
| {NULL:1, NULL:2, 1234567:77} | ||
| {NULL:12, 123:7777} | ||
|
|
||
| -- !sql10 -- | ||
| {NULL:NULL, NULL:NULL, 1234567:NULL} | ||
| {NULL:NULL, 123:NULL} | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("test_cast_map_function", "query") { | ||
| sql """ set enable_nereids_planner = true; """ | ||
|
Contributor
There was a problem hiding this comment. should also set |
||
| sql """ set enable_fallback_to_original_planner=false; """ | ||
| def tableName = "tbl_test_cast_map_function_nereids" | ||
|
|
||
| sql """DROP TABLE IF EXISTS ${tableName}""" | ||
| sql """ | ||
| CREATE TABLE IF NOT EXISTS ${tableName} ( | ||
| `k1` int(11) NULL COMMENT "", | ||
| `k2` Map<char(7), int(11)> NOT NULL COMMENT "", | ||
| ) ENGINE=OLAP | ||
| DUPLICATE KEY(`k1`) | ||
| DISTRIBUTED BY HASH(`k1`) BUCKETS 1 | ||
| PROPERTIES ( | ||
| "replication_allocation" = "tag.location.default: 1", | ||
| "storage_format" = "V2" | ||
| ) | ||
| """ | ||
| // insert into with implicit cast | ||
| sql """ INSERT INTO ${tableName} VALUES(1, {"aa": 1, "b": 2, "1234567": 77}) """ | ||
| sql """ INSERT INTO ${tableName} VALUES(2, {"b":12, "123":7777}) """ | ||
|
|
||
| qt_select """ select * from ${tableName} order by k1; """ | ||
|
|
||
| qt_select " select cast({} as MAP<INT,INT>);" | ||
| qt_select " select cast(map() as MAP<INT,INT>); " | ||
| qt_sql1 "select cast(NULL as MAP<string,int>)" | ||
|
|
||
| // literal NONSTRICT_SUPERTYPE_OF cast | ||
| qt_sql2 "select cast({'':''} as MAP<String,INT>);" | ||
| qt_sql3 "select cast({1:2} as MAP<String,INT>);" | ||
|
|
||
| // select SUPERTYPE_OF cast | ||
| qt_sql4 "select cast(k2 as map<varchar, bigint>) from ${tableName} order by k1;" | ||
|
|
||
| // select NONSTRICT_SUPERTYPE_OF cast , this behavior is same with nested scala type | ||
| qt_sql5 "select cast(k2 as map<char(2), smallint>) from ${tableName} order by k1;" | ||
| qt_sql6 "select cast(k2 as map<char(1), tinyint>) from ${tableName} order by k1;" | ||
| qt_sql7 "select cast(k2 as map<char, string>) from ${tableName} order by k1;" | ||
| qt_sql8 "select cast(k2 as map<int, string>) from ${tableName} order by k1;" | ||
| qt_sql9 "select cast(k2 as map<largeint, decimal>) from ${tableName} order by k1;" | ||
| qt_sql10 "select cast(k2 as map<double, datetime>) from ${tableName} order by k1;" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| suite("test_cast_map_function", "query") { | ||
| sql """set enable_nereids_planner = false """ | ||
| def tableName = "tbl_test_cast_map_function" | ||
|
Contributor
There was a problem hiding this comment. add some legacy planner cases?
Contributor
Author
There was a problem hiding this comment. u mean disable nereids ? |
||
| // array functions only supported in vectorized engine | ||
|
|
||
| sql """DROP TABLE IF EXISTS ${tableName}""" | ||
| sql """ | ||
| CREATE TABLE IF NOT EXISTS ${tableName} ( | ||
| `k1` int(11) NULL COMMENT "", | ||
| `k2` Map<char(7), int(11)> NOT NULL COMMENT "", | ||
| ) ENGINE=OLAP | ||
| DUPLICATE KEY(`k1`) | ||
| DISTRIBUTED BY HASH(`k1`) BUCKETS 1 | ||
| PROPERTIES ( | ||
| "replication_allocation" = "tag.location.default: 1", | ||
| "storage_format" = "V2" | ||
| ) | ||
| """ | ||
| // insert into with implicit cast | ||
| sql """ INSERT INTO ${tableName} VALUES(1, {"aa": 1, "b": 2, "1234567": 77}) """ | ||
| sql """ INSERT INTO ${tableName} VALUES(2, {"b":12, "123":7777}) """ | ||
|
|
||
| qt_select """ select * from ${tableName} order by k1; """ | ||
|
|
||
| qt_select " select cast({} as MAP<INT,INT>);" | ||
| qt_select " select cast(map() as MAP<INT,INT>); " | ||
| qt_sql1 "select cast(NULL as MAP<string,int>)" | ||
|
|
||
| // literal NONSTRICT_SUPERTYPE_OF cast | ||
| qt_sql2 "select cast({'':''} as MAP<String,INT>);" | ||
| qt_sql3 "select cast({1:2} as MAP<String,INT>);" | ||
|
|
||
| // select SUPERTYPE_OF cast | ||
| qt_sql4 "select cast(k2 as map<varchar, bigint>) from ${tableName} order by k1;" | ||
|
|
||
| // select NONSTRICT_SUPERTYPE_OF cast , this behavior is same with nested scala type | ||
| qt_sql5 "select cast(k2 as map<char(2), smallint>) from ${tableName} order by k1;" | ||
| qt_sql6 "select cast(k2 as map<char(1), tinyint>) from ${tableName} order by k1;" | ||
| qt_sql7 "select cast(k2 as map<char, string>) from ${tableName} order by k1;" | ||
| qt_sql8 "select cast(k2 as map<int, string>) from ${tableName} order by k1;" | ||
| qt_sql9 "select cast(k2 as map<largeint, decimal>) from ${tableName} order by k1;" | ||
| qt_sql10 "select cast(k2 as map<double, datetime>) from ${tableName} order by k1;" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.