Skip to content

[test](coverage) Improve test coverage for runtime filter #26314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel39 merged 1 commit into from
Nov 3, 2023
Merged

[test](coverage) Improve test coverage for runtime filter #26314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion be/src/vec/exec/runtime_filter_consumer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ class RuntimeFilterConsumer {

// For runtime filters
struct RuntimeFilterContext {
RuntimeFilterContext() : apply_mark(false), runtime_filter(nullptr) {}
RuntimeFilterContext(IRuntimeFilter* rf) : apply_mark(false), runtime_filter(rf) {}
// set to true if this runtime filter is already applied to vconjunct_ctx_ptr
bool apply_mark;
Expand Down
11 changes: 0 additions & 11 deletions be/src/vec/exprs/vruntimefilter_wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ namespace doris::vectorized {
VRuntimeFilterWrapper::VRuntimeFilterWrapper(const TExprNode& node, const VExprSPtr& impl)
: VExpr(node), _impl(impl), _always_true(false), _filtered_rows(0), _scan_rows(0) {}

VRuntimeFilterWrapper::VRuntimeFilterWrapper(const VRuntimeFilterWrapper& vexpr)
: VExpr(vexpr),
_impl(vexpr._impl),
_always_true(vexpr._always_true),
_filtered_rows(vexpr._filtered_rows.load()),
_scan_rows(vexpr._scan_rows.load()) {}

Status VRuntimeFilterWrapper::prepare(RuntimeState* state, const RowDescriptor& desc,
VExprContext* context) {
RETURN_IF_ERROR_OR_PREPARED(_impl->prepare(state, desc, context));
Expand All @@ -71,10 +64,6 @@ void VRuntimeFilterWrapper::close(VExprContext* context,
_impl->close(context, scope);
}

bool VRuntimeFilterWrapper::is_constant() const {
return _impl->is_constant();
}

Status VRuntimeFilterWrapper::execute(VExprContext* context, Block* block, int* result_column_id) {
if (_always_true) {
auto res_data_column = ColumnVector<UInt8>::create(block->rows(), 1);
Expand Down
2 changes: 0 additions & 2 deletions be/src/vec/exprs/vruntimefilter_wrapper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,12 @@ class VRuntimeFilterWrapper final : public VExpr {

public:
VRuntimeFilterWrapper(const TExprNode& node, const VExprSPtr& impl);
VRuntimeFilterWrapper(const VRuntimeFilterWrapper& vexpr);
~VRuntimeFilterWrapper() override = default;
Status execute(VExprContext* context, Block* block, int* result_column_id) override;
Status prepare(RuntimeState* state, const RowDescriptor& desc, VExprContext* context) override;
Status open(RuntimeState* state, VExprContext* context,
FunctionContext::FunctionStateScope scope) override;
std::string debug_string() const override { return _impl->debug_string(); }
bool is_constant() const override;
void close(VExprContext* context, FunctionContext::FunctionStateScope scope) override;
const std::string& expr_name() const override;
const VExprSPtrs& children() const override { return _impl->children(); }
Expand Down