Skip to content

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Nov 2, 2023

Proposed changes

The SQL : select * from table, the row of dt = 20220202 return [10000,10001,72173389]
But if SQL: select * from table where dt = 20220202 return [10001,72173389]
root reason is the bitmap value not clear, so it's shared from others.

bitmap_case

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangstar333
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.37% (8481/22693)
Line Coverage: 29.73% (68597/230724)
Region Coverage: 28.39% (35501/125034)
Branch Coverage: 25.13% (18121/72114)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9af7506d2ed4e3304bdd374316c5b3f42cad7e20_9af7506d2ed4e3304bdd374316c5b3f42cad7e20/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.61 seconds
stream load tsv: 555 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162069732 Bytes

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 509723c into apache:master Nov 3, 2023
@xiaokang xiaokang added the p0_w label Nov 3, 2023
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 5, 2023
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 8, 2023
@zhangstar333
Copy link
Contributor Author

#26451 this PR have contains the fix and have been merged to 2.0.3 and pick to branch-2.0

seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 12, 2023
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants