Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 52 additions & 6 deletions be/src/vec/functions/function_cast.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
#include "vec/aggregate_functions/aggregate_function.h"
#include "vec/columns/column.h"
#include "vec/columns/column_array.h"
#include "vec/columns/column_map.h"
#include "vec/columns/column_nullable.h"
#include "vec/columns/column_string.h"
#include "vec/columns/column_struct.h"
Expand Down Expand Up @@ -1852,13 +1853,57 @@ class FunctionCast final : public IFunctionBase {
}

//TODO(Amory) . Need support more cast for key , value for map
WrapperType create_map_wrapper(const DataTypePtr& from_type, const DataTypeMap& to_type) const {
switch (from_type->get_type_id()) {
case TypeIndex::String:
WrapperType create_map_wrapper(FunctionContext* context, const DataTypePtr& from_type,
const DataTypeMap& to_type) const {
if (from_type->get_type_id() == TypeIndex::String) {
return &ConvertImplGenericFromString::execute;
default:
return create_unsupport_wrapper(from_type->get_name(), to_type.get_name());
}
auto from = check_and_get_data_type<DataTypeMap>(from_type.get());
if (!from) {
return create_unsupport_wrapper(
fmt::format("CAST AS Map can only be performed between Map types or from "
"String. from type: {}, to type: {}",
from_type->get_name(), to_type.get_name()));
}
DataTypes from_kv_types;
DataTypes to_kv_types;
from_kv_types.reserve(2);
to_kv_types.reserve(2);
from_kv_types.push_back(from->get_key_type());
from_kv_types.push_back(from->get_value_type());
to_kv_types.push_back(to_type.get_key_type());
to_kv_types.push_back(to_type.get_value_type());

auto kv_wrappers = get_element_wrappers(context, from_kv_types, to_kv_types);
return [kv_wrappers, from_kv_types, to_kv_types](
FunctionContext* context, Block& block, const ColumnNumbers& arguments,
const size_t result, size_t /*input_rows_count*/) -> Status {
auto& from_column = block.get_by_position(arguments.front()).column;
auto from_col_map = check_and_get_column<ColumnMap>(from_column.get());
if (!from_col_map) {
return Status::RuntimeError("Illegal column {} for function CAST AS MAP",
from_column->get_name());
}

Columns converted_columns(2);
ColumnsWithTypeAndName columnsWithTypeAndName(2);
columnsWithTypeAndName[0] = {from_col_map->get_keys_ptr(), from_kv_types[0], ""};
columnsWithTypeAndName[1] = {from_col_map->get_values_ptr(), from_kv_types[1], ""};

for (size_t i = 0; i < 2; ++i) {
ColumnNumbers element_arguments {block.columns()};
block.insert(columnsWithTypeAndName[i]);
size_t element_result = block.columns();
block.insert({to_kv_types[i], ""});
RETURN_IF_ERROR(kv_wrappers[i](context, block, element_arguments, element_result,
columnsWithTypeAndName[i].column->size()));
converted_columns[i] = block.get_by_position(element_result).column;
}

block.get_by_position(result).column = ColumnMap::create(
converted_columns[0], converted_columns[1], from_col_map->get_offsets_ptr());
return Status::OK();
};
}

ElementWrappers get_element_wrappers(FunctionContext* context,
Expand Down Expand Up @@ -2115,7 +2160,8 @@ class FunctionCast final : public IFunctionBase {
return create_struct_wrapper(context, from_type,
static_cast<const DataTypeStruct&>(*to_type));
case TypeIndex::Map:
return create_map_wrapper(from_type, static_cast<const DataTypeMap&>(*to_type));
return create_map_wrapper(context, from_type,
static_cast<const DataTypeMap&>(*to_type));
case TypeIndex::HLL:
return create_hll_wrapper(context, from_type,
static_cast<const DataTypeHLL&>(*to_type));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,10 @@ protected String prettyPrint(int lpad) {
}

public static boolean canCastTo(MapType type, MapType targetType) {
return Type.canCastTo(type.getKeyType(), targetType.getKeyType())
&& Type.canCastTo(type.getValueType(), targetType.getValueType());
return (targetType.getKeyType().isStringType() && type.getKeyType().isStringType()
|| Type.canCastTo(type.getKeyType(), targetType.getKeyType()))
&& (Type.canCastTo(type.getValueType(), targetType.getValueType())
|| targetType.getValueType().isStringType() && type.getValueType().isStringType());
}

@Override
Expand Down
11 changes: 11 additions & 0 deletions fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
Original file line number Diff line number Diff line change
Expand Up @@ -1967,6 +1967,17 @@ public static boolean matchExactType(Type type1, Type type2, boolean ignorePreci
return false;
}
return matchExactType(((ArrayType) type2).getItemType(), ((ArrayType) type1).getItemType());
} else if (type2.isMapType()) {
// For types array, we also need to check contains null for case like
// cast(array<not_null(int)> as array<int>)
if (!((MapType) type2).getIsKeyContainsNull() == ((MapType) type1).getIsKeyContainsNull()) {
return false;
}
if (!((MapType) type2).getIsValueContainsNull() == ((MapType) type1).getIsValueContainsNull()) {
return false;
}
return matchExactType(((MapType) type2).getKeyType(), ((MapType) type1).getKeyType())
&& matchExactType(((MapType) type2).getValueType(), ((MapType) type1).getValueType());
} else {
return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ private void createComplexTypeCastFunction() {
} else if (type.isMapType()) {
fn = ScalarFunction.createBuiltin(getFnName(Type.MAP),
type, Function.NullableMode.ALWAYS_NULLABLE,
Lists.newArrayList(Type.VARCHAR), false,
Lists.newArrayList(getActualArgTypes(collectChildReturnTypes())[0]), false,
"doris::CastFunctions::cast_to_map_val", null, null, true);
} else if (type.isStructType()) {
fn = ScalarFunction.createBuiltin(getFnName(Type.STRUCT),
Expand Down
7 changes: 7 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.doris.catalog.Function;
import org.apache.doris.catalog.Function.NullableMode;
import org.apache.doris.catalog.FunctionSet;
import org.apache.doris.catalog.MapType;
import org.apache.doris.catalog.MaterializedIndexMeta;
import org.apache.doris.catalog.PrimitiveType;
import org.apache.doris.catalog.ScalarFunction;
Expand Down Expand Up @@ -2489,6 +2490,8 @@ protected Type getActualType(Type originType) {
return getActualScalarType(originType);
} else if (originType.getPrimitiveType() == PrimitiveType.ARRAY) {
return getActualArrayType((ArrayType) originType);
} else if (originType.getPrimitiveType().isMapType()) {
return getActualMapType((MapType) originType);
} else {
return originType;
}
Expand Down Expand Up @@ -2521,6 +2524,10 @@ protected Type[] getActualArgTypes(Type[] originType) {
return Arrays.stream(originType).map(this::getActualType).toArray(Type[]::new);
}

private MapType getActualMapType(MapType originMapType) {
return new MapType(getActualType(originMapType.getKeyType()), getActualType(originMapType.getValueType()));
}

private ArrayType getActualArrayType(ArrayType originArrayType) {
return new ArrayType(getActualType(originArrayType.getItemType()));
}
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !select --
1 {"aa":1, "b":2, "1234567":77}
2 {"b":12, "123":7777}

-- !select --
{}

-- !select --
{}

-- !sql1 --
\N

-- !sql2 --
{"":NULL}

-- !sql3 --
{"1":2}

-- !sql4 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":7777}

-- !sql5 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":7777}

-- !sql6 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":97}

-- !sql7 --
{"aa":"1", "b":"2", "1234567":"77"}
{"b":"12", "123":"7777"}

-- !sql8 --
{NULL:"1", NULL:"2", 1234567:"77"}
{NULL:"12", 123:"7777"}

-- !sql9 --
{NULL:1, NULL:2, 1234567:77}
{NULL:12, 123:7777}

-- !sql10 --
{NULL:NULL, NULL:NULL, 1234567:NULL}
{NULL:NULL, 123:NULL}

Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
-- This file is automatically generated. You should know what you did if you want to edit this
-- !select --
1 {"aa":1, "b":2, "1234567":77}
2 {"b":12, "123":7777}

-- !select --
{}

-- !select --
{}

-- !sql1 --
\N

-- !sql2 --
{"":NULL}

-- !sql3 --
{"1":2}

-- !sql4 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":7777}

-- !sql5 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":7777}

-- !sql6 --
{"aa":1, "b":2, "1234567":77}
{"b":12, "123":97}

-- !sql7 --
{"aa":"1", "b":"2", "1234567":"77"}
{"b":"12", "123":"7777"}

-- !sql8 --
{NULL:"1", NULL:"2", 1234567:"77"}
{NULL:"12", 123:"7777"}

-- !sql9 --
{NULL:1, NULL:2, 1234567:77}
{NULL:12, 123:7777}

-- !sql10 --
{NULL:NULL, NULL:NULL, 1234567:NULL}
{NULL:NULL, 123:NULL}

Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_cast_map_function", "query") {
sql """ set enable_nereids_planner = true; """
sql """ set enable_fallback_to_original_planner=false; """
def tableName = "tbl_test_cast_map_function_nereids"

sql """DROP TABLE IF EXISTS ${tableName}"""
sql """
CREATE TABLE IF NOT EXISTS ${tableName} (
`k1` int(11) NULL COMMENT "",
`k2` Map<char(7), int(11)> NOT NULL COMMENT "",
) ENGINE=OLAP
DUPLICATE KEY(`k1`)
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"storage_format" = "V2"
)
"""
// insert into with implicit cast
sql """ INSERT INTO ${tableName} VALUES(1, {"aa": 1, "b": 2, "1234567": 77}) """
sql """ INSERT INTO ${tableName} VALUES(2, {"b":12, "123":7777}) """

qt_select """ select * from ${tableName} order by k1; """

qt_select " select cast({} as MAP<INT,INT>);"
qt_select " select cast(map() as MAP<INT,INT>); "
qt_sql1 "select cast(NULL as MAP<string,int>)"

// literal NONSTRICT_SUPERTYPE_OF cast
qt_sql2 "select cast({'':''} as MAP<String,INT>);"
qt_sql3 "select cast({1:2} as MAP<String,INT>);"

// select SUPERTYPE_OF cast
qt_sql4 "select cast(k2 as map<varchar, bigint>) from ${tableName} order by k1;"

// select NONSTRICT_SUPERTYPE_OF cast , this behavior is same with nested scala type
qt_sql5 "select cast(k2 as map<char(2), smallint>) from ${tableName} order by k1;"
qt_sql6 "select cast(k2 as map<char(1), tinyint>) from ${tableName} order by k1;"
qt_sql7 "select cast(k2 as map<char, string>) from ${tableName} order by k1;"
qt_sql8 "select cast(k2 as map<int, string>) from ${tableName} order by k1;"
qt_sql9 "select cast(k2 as map<largeint, decimal>) from ${tableName} order by k1;"
qt_sql10 "select cast(k2 as map<double, datetime>) from ${tableName} order by k1;"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_cast_map_function", "query") {
sql """set enable_nereids_planner = false """
def tableName = "tbl_test_cast_map_function"
// array functions only supported in vectorized engine

sql """DROP TABLE IF EXISTS ${tableName}"""
sql """
CREATE TABLE IF NOT EXISTS ${tableName} (
`k1` int(11) NULL COMMENT "",
`k2` Map<char(7), int(11)> NOT NULL COMMENT "",
) ENGINE=OLAP
DUPLICATE KEY(`k1`)
DISTRIBUTED BY HASH(`k1`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"storage_format" = "V2"
)
"""
// insert into with implicit cast
sql """ INSERT INTO ${tableName} VALUES(1, {"aa": 1, "b": 2, "1234567": 77}) """
sql """ INSERT INTO ${tableName} VALUES(2, {"b":12, "123":7777}) """

qt_select """ select * from ${tableName} order by k1; """

qt_select " select cast({} as MAP<INT,INT>);"
qt_select " select cast(map() as MAP<INT,INT>); "
qt_sql1 "select cast(NULL as MAP<string,int>)"

// literal NONSTRICT_SUPERTYPE_OF cast
qt_sql2 "select cast({'':''} as MAP<String,INT>);"
qt_sql3 "select cast({1:2} as MAP<String,INT>);"

// select SUPERTYPE_OF cast
qt_sql4 "select cast(k2 as map<varchar, bigint>) from ${tableName} order by k1;"

// select NONSTRICT_SUPERTYPE_OF cast , this behavior is same with nested scala type
qt_sql5 "select cast(k2 as map<char(2), smallint>) from ${tableName} order by k1;"
qt_sql6 "select cast(k2 as map<char(1), tinyint>) from ${tableName} order by k1;"
qt_sql7 "select cast(k2 as map<char, string>) from ${tableName} order by k1;"
qt_sql8 "select cast(k2 as map<int, string>) from ${tableName} order by k1;"
qt_sql9 "select cast(k2 as map<largeint, decimal>) from ${tableName} order by k1;"
qt_sql10 "select cast(k2 as map<double, datetime>) from ${tableName} order by k1;"
}