Skip to content

[improve](nereids) support agg function of count(const value) pushdown #26677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangstar333 merged 1 commit into from
Nov 23, 2023
Merged

[improve](nereids) support agg function of count(const value) pushdown #26677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/CountLiteralToCountStar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ private boolean rewriteCountLiteral(List<NamedExpression> oldExprs, List<NamedEx
.filter(this::isCountLiteral)
.forEach(c -> replaced.put(c, new Count()));
expr = expr.rewriteUp(s -> replaced.getOrDefault(s, s));
changed = !replaced.isEmpty();
changed |= !replaced.isEmpty();
newExprs.add((NamedExpression) expr);
}
return changed;
Expand Down
40 changes: 40 additions & 0 deletions regression-test/suites/nereids_p0/explain/test_pushdown_explain.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,44 @@ suite("test_pushdown_explain") {
contains "PREDICATES:"
}
qt_select "select k1 from baseall where k1 = 1"

sql "DROP TABLE IF EXISTS test_lineorder"
sql """ CREATE TABLE `test_lineorder` (
`lo_orderkey` INT NOT NULL COMMENT '\"\"',
`lo_linenumber` INT NOT NULL COMMENT '\"\"',
`lo_shipmode` VARCHAR(11) NOT NULL COMMENT '\"\"'
) ENGINE=OLAP
DUPLICATE KEY(`lo_orderkey`)
DISTRIBUTED BY HASH(`lo_orderkey`) BUCKETS 48
PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"min_load_replica_num" = "-1",
"is_being_synced" = "false",
"colocate_with" = "groupa1",
"storage_format" = "V2",
"light_schema_change" = "true",
"disable_auto_compaction" = "false",
"enable_single_replica_compaction" = "false"
); """
sql """ insert into test_lineorder values(1,2,"asd"); """
explain {
sql("select count(1) from test_lineorder;")
contains "pushAggOp=COUNT"
}
explain {
sql("select count(*) from test_lineorder;")
contains "pushAggOp=COUNT"
}
explain {
sql("select count(1) - count(lo_shipmode) from test_lineorder;")
contains "pushAggOp=COUNT"
}
explain {
sql("select count(lo_orderkey) from test_lineorder;")
contains "pushAggOp=COUNT"
}
explain {
sql("select count(cast(lo_orderkey as bigint)) from test_lineorder;")
contains "pushAggOp=COUNT"
}
}