[regression-test](group commit) modify some case to make group commit can run all case #26856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
mymeiyi
force-pushed
the
enable-group-commit
branch
from
19a463f to
699afff
Compare
Contributor
Author
|
run compile,p0 |
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
mymeiyi
force-pushed
the
enable-group-commit
branch
2 times, most recently
from
f7aadb7 to
367fd3f
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
mymeiyi
force-pushed
the
enable-group-commit
branch
from
f9be88e to
4239424
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 172922 ms |
ClickBench: Total hot run time: 30.47 s |
mymeiyi
force-pushed
the
enable-group-commit
branch
from
b92ea45 to
e569463
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40433 ms |
TPC-DS: Total hot run time: 174363 ms |
ClickBench: Total hot run time: 30.5 s |
mymeiyi
force-pushed
the
enable-group-commit
branch
from
e569463 to
07eaf4f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39986 ms |
TPC-DS: Total hot run time: 174286 ms |
ClickBench: Total hot run time: 31.03 s |
Contributor
Author
|
run p0 |
mymeiyi
force-pushed
the
enable-group-commit
branch
from
07eaf4f to
49b5796
Compare
mymeiyi
force-pushed
the
enable-group-commit
branch
from
49b5796 to
4e471d5
Compare
Contributor
Author
|
run buildall |
mymeiyi
changed the title
mymeiyi
changed the title
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
Yukang-Lian
approved these changes
Jul 11, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
… can run all case (apache#26856) ## Proposed changes Enable `wait_internal_group_commit_finish` to check if all cases can pass: fe.conf ``` wait_internal_group_commit_finish=true group_commit_interval_ms_default_value=2 ``` be.conf ``` wait_internal_group_commit_finish=true ``` some cases are not compitable, add `excludeSuites` in `regression-conf.groovy`: ``` "test_group_commit_data_bytes_property,test_group_commit_interval_ms_property,insert_group_commit_into_unique_sync_mode,insert_group_commit_into_max_filter_ratio,test_group_commit_stream_load,test_wal_mem_back_pressure_fault_injection," + "test_table_options,test_show_transaction,test_base_insert_job,test_show_create_table_and_views,test_show_create_table_and_views_nereids,test_get_stream_load_state,test_ctas,test_publish_timeout," + "test_array_insert_overflow," + ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
… can run all case (#26856) ## Proposed changes Enable `wait_internal_group_commit_finish` to check if all cases can pass: fe.conf ``` wait_internal_group_commit_finish=true group_commit_interval_ms_default_value=2 ``` be.conf ``` wait_internal_group_commit_finish=true ``` some cases are not compitable, add `excludeSuites` in `regression-conf.groovy`: ``` "test_group_commit_data_bytes_property,test_group_commit_interval_ms_property,insert_group_commit_into_unique_sync_mode,insert_group_commit_into_max_filter_ratio,test_group_commit_stream_load,test_wal_mem_back_pressure_fault_injection," + "test_table_options,test_show_transaction,test_base_insert_job,test_show_create_table_and_views,test_show_create_table_and_views_nereids,test_get_stream_load_state,test_ctas,test_publish_timeout," + "test_array_insert_overflow," + ``` ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Enable
wait_internal_group_commit_finishto check if all cases can pass:fe.conf
be.conf
some cases are not compitable, add
excludeSuitesinregression-conf.groovy:Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...