Skip to content

[fix](statistics)Fix external table show column stats type bug. #26921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Nov 14, 2023
Merged

[fix](statistics)Fix external table show column stats type bug. #26921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ protected AnalysisInfo buildAndAssignJob(AnalyzeTblStmt stmt) throws DdlExceptio
constructJob(jobInfo, analysisTaskInfos.values());
if (isSync) {
syncExecute(analysisTaskInfos.values());
jobInfo.state = AnalysisState.FINISHED;
updateTableStats(jobInfo);
return null;
}
Expand Down Expand Up @@ -593,8 +594,9 @@ public void updateTaskStatus(AnalysisInfo info, AnalysisState taskState, String
public void updateTableStats(AnalysisInfo jobInfo) {
TableIf tbl = StatisticsUtil.findTable(jobInfo.catalogId,
jobInfo.dbId, jobInfo.tblId);
// External Table update table stats after table level task finished.
if (tbl instanceof ExternalTable) {
// External Table only update table stats when all tasks finished.
// Because it needs to get the row count from the result of row count task.
if (tbl instanceof ExternalTable && !jobInfo.state.equals(AnalysisState.FINISHED)) {
return;
}
TableStatsMeta tableStats = findTableStatsStatus(tbl.getId());
Expand Down
45 changes: 44 additions & 1 deletion regression-test/suites/external_table_p0/hive/test_hive_statistics_p0.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("4.0", result[0][5])
assertEquals("1", result[0][6])
assertEquals("3", result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

result = sql """show column stats stats_test1(value);"""
assertEquals(1, result.size())
Expand All @@ -77,6 +81,10 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("5.0", result[0][5])
assertEquals("\'name1\'" , result[0][6])
assertEquals("\'name3\'" , result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

result = sql """show column stats stats_test2(id);"""
assertEquals(1, result.size())
Expand All @@ -88,6 +96,10 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("4.0", result[0][5])
assertEquals("1", result[0][6])
assertEquals("2", result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

result = sql """show column stats stats_test2(value);"""
assertEquals(1, result.size())
Expand All @@ -99,6 +111,10 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("1.0", result[0][5])
assertEquals("\'*\'", result[0][6])
assertEquals("\';\'", result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

sql """drop catalog if exists ${catalog_name}"""

Expand All @@ -118,10 +134,30 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("5.0", result[0][5])
assertEquals("\'name1\'" , result[0][6])
assertEquals("\'name3\'" , result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

result = sql """show column stats stats_test1(id);"""
assertEquals(0, result.size())

sql """analyze table stats_test1(id) with sync with sample rows 100"""
result = sql """show column stats stats_test1(id);"""
assertEquals(1, result.size())
assertEquals("id", result[0][0])
assertEquals("3.0", result[0][1])
assertEquals("3.0", result[0][2])
assertEquals("0.0", result[0][3])
assertEquals("12.0", result[0][4])
assertEquals("4.0", result[0][5])
assertEquals("N/A", result[0][6])
assertEquals("N/A", result[0][7])
assertEquals("SAMPLE" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

sql """analyze table stats_test2 with sync;"""
result = sql """show column stats stats_test2(id);"""
assertEquals(1, result.size())
Expand All @@ -133,6 +169,10 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("4.0", result[0][5])
assertEquals("1", result[0][6])
assertEquals("2", result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])

result = sql """show column stats stats_test2(value);"""
assertEquals(1, result.size())
Expand All @@ -144,8 +184,11 @@ suite("test_hive_statistics_p0", "all_types,p0,external,hive,external_docker,ext
assertEquals("1.0", result[0][5])
assertEquals("\'*\'", result[0][6])
assertEquals("\';\'", result[0][7])
assertEquals("FULL" , result[0][8])
assertEquals("FUNDAMENTALS" , result[0][9])
assertEquals("MANUAL" , result[0][10])
assertEquals("0" , result[0][11])
sql """drop catalog if exists ${catalog_name}"""

} finally {
}
}
Expand Down