Skip to content

[fix](statistics)Fix alter column stats bug (#27093) #27189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Nov 17, 2023
Merged

[fix](statistics)Fix alter column stats bug (#27093) #27189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

import java.nio.charset.StandardCharsets;
import java.util.Base64;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -269,16 +271,18 @@ public static void alterColumnStatistics(AlterColumnStatsStmt alterColumnStatsSt
params.put("count", String.valueOf(columnStatistic.count));
params.put("ndv", String.valueOf(columnStatistic.ndv));
params.put("nullCount", String.valueOf(columnStatistic.numNulls));
params.put("min", min == null ? "NULL" : min);
params.put("max", max == null ? "NULL" : max);
params.put("min", min == null ? "NULL" :
Base64.getEncoder().encodeToString(min.getBytes(StandardCharsets.UTF_8)));
params.put("max", max == null ? "NULL" :
Base64.getEncoder().encodeToString(max.getBytes(StandardCharsets.UTF_8)));
params.put("dataSize", String.valueOf(columnStatistic.dataSize));

if (partitionIds.isEmpty()) {
// update table granularity statistics
params.put("partId", "NULL");
StatisticsUtil.execUpdate(INSERT_INTO_COLUMN_STATISTICS, params);
Env.getCurrentEnv().getStatisticsCache()
.updateColStatsCache(objects.table.getId(), -1, colName, builder.build());
.updateColStatsCache(objects.table.getId(), -1, colName, columnStatistic);
} else {
// update partition granularity statistics
for (Long partitionId : partitionIds) {
Expand Down
39 changes: 39 additions & 0 deletions regression-test/suites/external_table_p2/hive/test_hive_statistic.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,45 @@ suite("test_hive_statistic", "p2") {
assertEquals(result.size(), 1)
assertEquals(result[0][6], "N/A")
assertEquals(result[0][7], "N/A")

sql """use tpch1_parquet;"""
sql """drop stats region"""
sql """alter table region modify column r_comment set stats ('row_count'='5.0', 'ndv'='5.0', 'num_nulls'='0.0', 'data_size'='330.0', 'min_value'='ges. thinly even pinto beans ca', 'max_value'='uickly special accounts cajole carefully blithely close requests. carefully final asymptotes haggle furiousl');"""
sql """alter table region modify column r_name set stats ('row_count'='5.0', 'ndv'='5.0', 'num_nulls'='0.0', 'data_size'='34.0', 'min_value'='AFRICA', 'max_value'='MIDDLE EAST');"""
sql """alter table region modify column r_regionkey set stats ('row_count'='5.0', 'ndv'='5.0', 'num_nulls'='0.0', 'data_size'='20.0', 'min_value'='0', 'max_value'='4');"""
result = sql """show column stats region(r_regionkey)"""
assertEquals(result.size(), 1)
assertEquals(result[0][0], "r_regionkey")
assertEquals(result[0][1], "5.0")
assertEquals(result[0][2], "5.0")
assertEquals(result[0][3], "0.0")
assertEquals(result[0][4], "20.0")
assertEquals(result[0][5], "4.0")
assertEquals(result[0][6], "0")
assertEquals(result[0][7], "4")

result = sql """show column stats region(r_comment)"""
assertEquals(result.size(), 1)
assertEquals(result[0][0], "r_comment")
assertEquals(result[0][1], "5.0")
assertEquals(result[0][2], "5.0")
assertEquals(result[0][3], "0.0")
assertEquals(result[0][4], "330.0")
assertEquals(result[0][5], "66.0")
assertEquals(result[0][6], "\'ges. thinly even pinto beans ca\'")
assertEquals(result[0][7], "\'uickly special accounts cajole carefully blithely close requests. carefully final asymptotes haggle furiousl\'")

result = sql """show column stats region(r_name)"""
assertEquals(result.size(), 1)
assertEquals(result[0][0], "r_name")
assertEquals(result[0][1], "5.0")
assertEquals(result[0][2], "5.0")
assertEquals(result[0][3], "0.0")
assertEquals(result[0][4], "34.0")
assertEquals(result[0][5], "6.8")
assertEquals(result[0][6], "\'AFRICA\'")
assertEquals(result[0][7], "\'MIDDLE EAST\'")

sql """drop catalog ${catalog_name}"""
}
}
Expand Down