Skip to content

[fix](stats) Fix thread leaks when doing checkpoint #27334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Nov 23, 2023
Merged

[fix](stats) Fix thread leaks when doing checkpoint #27334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ public AnalysisManager() {
if (!Env.isCheckpointThread()) {
this.taskExecutor = new AnalysisTaskExecutor(Config.statistics_simultaneously_running_task_num);
this.statisticsCache = new StatisticsCache();
taskExecutor.start();
}
}

Expand Down
11 changes: 2 additions & 9 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/AnalysisTaskExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
import java.util.concurrent.ThreadPoolExecutor;
import java.util.concurrent.TimeUnit;

public class AnalysisTaskExecutor extends Thread {
public class AnalysisTaskExecutor {

private static final Logger LOG = LogManager.getLogger(AnalysisTaskExecutor.class);

Expand All @@ -50,19 +50,12 @@ public AnalysisTaskExecutor(int simultaneouslyRunningTaskNum) {
TimeUnit.DAYS, new LinkedBlockingQueue<>(),
new BlockedPolicy("Analysis Job Executor", Integer.MAX_VALUE),
"Analysis Job Executor", true);
cancelExpiredTask();
Copy link
Contributor

@Jibing-Li Jibing-Li Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cancelExpiredTask will only executed once?

Copy link
Contributor Author

@Kikyou1997 Kikyou1997 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would submit a thread to do this job

Copy link
Contributor

@Jibing-Li Jibing-Li Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, cancelExpiredTask this function will create a thread.
I think we need to sleep for a while between two iterations, or this thread may use too much cpu resource.

Copy link
Contributor Author

@Kikyou1997 Kikyou1997 Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It try to take elements from a blocking queue and then block until timeout, so won't cost too much CPU

} else {
executors = null;
}
}

@Override
public void run() {
if (Env.isCheckpointThread()) {
return;
}
cancelExpiredTask();
}

private void cancelExpiredTask() {
String name = "Expired Analysis Task Killer";
Thread t = new Thread(this::doCancelExpiredJob, name);
Expand Down
1 change: 0 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCollector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ public abstract class StatisticsCollector extends MasterDaemon {
public StatisticsCollector(String name, long intervalMs, AnalysisTaskExecutor analysisTaskExecutor) {
super(name, intervalMs);
this.analysisTaskExecutor = analysisTaskExecutor;
analysisTaskExecutor.start();
}

@Override
Expand Down