Skip to content

[chore](merge-on-write) disable rowid conversion check for mow table by default (#27482) #27508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 1 commit into from
Nov 24, 2023
Merged

[chore](merge-on-write) disable rowid conversion check for mow table by default (#27482) #27508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions be/src/common/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,8 @@ DEFINE_mInt64(lookup_connection_cache_bytes_limit, "4294967296");
DEFINE_mInt64(LZ4_HC_compression_level, "9");

DEFINE_mBool(enable_merge_on_write_correctness_check, "true");
// rowid conversion correctness check when compaction for mow table
DEFINE_mBool(enable_rowid_conversion_correctness_check, "false");

// The secure path with user files, used in the `local` table function.
DEFINE_mString(user_files_secure_path, "${DORIS_HOME}");
Expand Down
2 changes: 2 additions & 0 deletions be/src/common/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,6 +1121,8 @@ DECLARE_mInt64(lookup_connection_cache_bytes_limit);
DECLARE_mInt64(LZ4_HC_compression_level);

DECLARE_mBool(enable_merge_on_write_correctness_check);
// rowid conversion correctness check when compaction for mow table
DECLARE_mBool(enable_rowid_conversion_correctness_check);

// The secure path with user files, used in the `local` table function.
DECLARE_mString(user_files_secure_path);
Expand Down
8 changes: 6 additions & 2 deletions be/src/olap/compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
}
}

RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
if (config::enable_rowid_conversion_correctness_check) {
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
}
location_map.clear();

{
Expand Down Expand Up @@ -755,7 +757,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
}
}

RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
if (config::enable_rowid_conversion_correctness_check) {
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
}

_tablet->merge_delete_bitmap(output_rowset_delete_bitmap);
RETURN_IF_ERROR(_tablet->modify_rowsets(output_rowsets, _input_rowsets, true));
Expand Down