Skip to content

[bugfix](topn) fix coredump in copy_column_data_to_block when nullable mismatch #27765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Nov 29, 2023
Merged

[bugfix](topn) fix coredump in copy_column_data_to_block when nullable mismatch #27765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions be/src/vec/core/block.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ class Block {
reinterpret_cast<vectorized::ColumnNullable*>(raw_res_ptr.get());
col_ptr_nullable->get_null_map_column().insert_many_defaults(select_size);
raw_res_ptr = col_ptr_nullable->get_nested_column_ptr();
} else if (!raw_res_ptr->is_nullable() && input_col_ptr->is_nullable()) {
LOG(WARNING) << "nullable mismatch for raw_res_column: "
<< this->get_by_position(block_cid).dump_structure()
<< " input_column: " << input_col_ptr->dump_structure()
<< " block_cid: " << block_cid << " select_size: " << select_size;
return Status::RuntimeError("copy_column_data_to_block nullable mismatch");
}

return input_col_ptr->filter_by_selector(sel_rowid_idx, select_size, raw_res_ptr);
Expand Down