Skip to content

[fix](invert index) fix reader does not close fd #27917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Dec 3, 2023
Merged

[fix](invert index) fix reader does not close fd #27917

xiaokang merged 1 commit into from
Dec 3, 2023

Conversation

@zzzxl1993
Copy link
Contributor

@zzzxl1993 zzzxl1993 commented Dec 3, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zzzxl1993
Copy link
Contributor Author

zzzxl1993 commented Dec 3, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

xiaokang
xiaokang approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2023

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Dec 3, 2023

TeamCity be ut coverage result:
Function Coverage: 37.96% (7984/21035)
Line Coverage: 29.66% (64776/218377)
Region Coverage: 29.08% (33346/114656)
Branch Coverage: 24.95% (17129/68658)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b3f7a6ed9643dbfb25864a30fc67d341857e4667_b3f7a6ed9643dbfb25864a30fc67d341857e4667/report/index.html

@doris-robot
Copy link

doris-robot commented Dec 3, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.18 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17167774858 Bytes

@xiaokang xiaokang merged commit ffa4079 into apache:branch-2.0 Dec 3, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Dec 4, 2023
@zzzxl1993
[fix](invert index) fix reader does not close fd (apache#27917)
04b0b4b
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 5, 2023
@zzzxl1993 @eldenmoon
[fix](invert index) fix reader does not close fd (apache#27917)
e8a4446
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Dec 5, 2023
@zzzxl1993 @eldenmoon
[fix](invert index) fix reader does not close fd (apache#27917)
24bb5ea
eldenmoon added a commit that referenced this pull request Dec 5, 2023
@eldenmoon @zzzxl1993 @jackwener
[pick](branch-2.0) cherry pick from branch-2.0 (#27984)
21303b9 
* [fix](invert index) fix reader does not close fd (#27917)

* [chore](Nereids): use debug to show phase of nereids into Branch-2.0(#27907)

(cherry picked from commit 72b2a33)

* [fix](Nereids): fix datetime fold-constant-be in Branch-2.0 (#27938)

fix fold-constant-be datetimev2 will lose the scale of datetime.

---------

Co-authored-by: zzzxl <33418555+zzzxl1993@users.noreply.github.com>
Co-authored-by: jakevin <jakevingoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.3-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zzzxl1993 @doris-robot @xiaokang