Skip to content

[fix](block) add block columns size dcheck #28539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Dec 23, 2023
Merged

[fix](block) add block columns size dcheck #28539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions be/src/vec/core/block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,15 +584,19 @@ MutableColumns Block::mutate_columns() {
}

void Block::set_columns(MutableColumns&& columns) {
/// TODO: assert if |columns| doesn't match |data|!
DCHECK_GE(columns.size(), data.size())
<< fmt::format("Invalid size of columns, columns size: {}, data size: {}",
columns.size(), data.size());
size_t num_columns = data.size();
for (size_t i = 0; i < num_columns; ++i) {
data[i].column = std::move(columns[i]);
}
}

void Block::set_columns(const Columns& columns) {
/// TODO: assert if |columns| doesn't match |data|!
DCHECK_GE(columns.size(), data.size())
<< fmt::format("Invalid size of columns, columns size: {}, data size: {}",
columns.size(), data.size());
size_t num_columns = data.size();
for (size_t i = 0; i < num_columns; ++i) {
data[i].column = columns[i];
Expand Down