Skip to content

Conversation

@yujun777
Copy link
Contributor

pick: #27693

If gc shutdown tablets take a lot time, it will make TabletManager getting a tablet wait a lot time.

pr #26151 had fix get a running tablet wait a lot time. Also it fix drop a tablet hold a tablet meta lock too long.

But it hadn't fix get a deleted tablet wait a log time. So this pr fix this.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@yujun777
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (7993/21138)
Line Coverage: 29.49% (64901/220070)
Region Coverage: 28.97% (33394/115274)
Branch Coverage: 24.84% (17136/68980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9473840f77bde2cefdbde968309e13a2bf869aac_9473840f77bde2cefdbde968309e13a2bf869aac/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.75 seconds
stream load tsv: 578 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17163051627 Bytes

@yujun777
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (7993/21138)
Line Coverage: 29.49% (64897/220070)
Region Coverage: 28.97% (33392/115275)
Branch Coverage: 24.84% (17136/68980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9473840f77bde2cefdbde968309e13a2bf869aac_9473840f77bde2cefdbde968309e13a2bf869aac/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.9 seconds
stream load tsv: 582 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.7 seconds inserted 10000000 Rows, about 336K ops/s
storage size: 17162086565 Bytes

@xiaokang xiaokang merged commit 64d27f3 into apache:branch-2.0 Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants