Skip to content

[fix](retry) Set query encounter rpc exception default retry times to 3 #28555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 15, 2024
Merged

[fix](retry) Set query encounter rpc exception default retry times to 3 #28555

dataroaring merged 1 commit into from
Mar 15, 2024

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Dec 18, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@deardeng
Copy link
Contributor Author

deardeng commented Dec 18, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 18, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.44 seconds
stream load tsv: 583 seconds loaded 74807831229 Bytes, about 122 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.1 seconds inserted 10000000 Rows, about 343K ops/s
storage size: 17222180119 Bytes

@doris-robot
Copy link

doris-robot commented Dec 18, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 34821b9f25f0e18524f0a53a059eceef65872677, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4701	4483	4496	4483
q2	364	160	158	158
q3	1454	1259	1218	1218
q4	1110	878	898	878
q5	3109	3127	3143	3127
q6	245	126	131	126
q7	976	489	489	489
q8	2215	2205	2177	2177
q9	6706	6635	6637	6635
q10	3207	3268	3247	3247
q11	327	202	203	202
q12	350	208	205	205
q13	4549	3817	3807	3807
q14	246	210	215	210
q15	565	526	527	526
q16	440	387	382	382
q17	993	604	513	513
q18	7211	6901	6860	6860
q19	1539	1411	1440	1411
q20	515	299	302	299
q21	3076	2660	2653	2653
q22	346	278	281	278
Total cold run time: 44244 ms
Total hot run time: 39884 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4408	4403	4370	4370
q2	265	163	175	163
q3	3535	3521	3515	3515
q4	2373	2354	2348	2348
q5	5724	5717	5736	5717
q6	239	120	121	120
q7	2395	1885	1856	1856
q8	3510	3511	3501	3501
q9	8980	8983	8974	8974
q10	3915	3988	3986	3986
q11	502	376	394	376
q12	769	615	602	602
q13	4296	3556	3598	3556
q14	290	245	254	245
q15	562	522	520	520
q16	522	450	445	445
q17	1894	1827	1860	1827
q18	8628	8113	8207	8113
q19	1732	1764	1745	1745
q20	2268	1948	1922	1922
q21	6508	6158	6156	6156
q22	500	440	424	424
Total cold run time: 63815 ms
Total hot run time: 60481 ms

dataroaring
dataroaring approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 19, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2023

PR approved by anyone and no changes requested.

@deardeng
Copy link
Contributor Author

deardeng commented Dec 21, 2023

run buildall

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Tpch sf100 test result on commit 34821b9f25f0e18524f0a53a059eceef65872677, data reload: false

run tpch-sf100 query with default conf and session variables
q1	4713	4422	4421	4421
q2	371	143	160	143
q3	1457	1299	1207	1207
q4	1115	931	899	899
q5	3167	3152	3169	3152
q6	250	126	130	126
q7	1023	506	488	488
q8	2202	2196	2199	2196
q9	6682	6623	6666	6623
q10	3239	3271	3287	3271
q11	310	192	197	192
q12	358	219	214	214
q13	4592	3843	3826	3826
q14	250	220	217	217
q15	571	530	519	519
q16	453	402	395	395
q17	995	586	577	577
q18	7292	6928	6915	6915
q19	1513	1356	1437	1356
q20	513	300	331	300
q21	3092	2647	2649	2647
q22	365	299	298	298
Total cold run time: 44523 ms
Total hot run time: 39982 ms

run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1	4358	4371	4350	4350
q2	272	167	175	167
q3	3535	3521	3523	3521
q4	2389	2370	2370	2370
q5	5746	5735	5751	5735
q6	240	124	123	123
q7	2392	1886	1871	1871
q8	3529	3529	3528	3528
q9	9078	9023	9044	9023
q10	3918	4009	4001	4001
q11	491	392	381	381
q12	774	599	619	599
q13	4311	3586	3555	3555
q14	283	259	253	253
q15	576	520	522	520
q16	519	490	516	490
q17	1888	1871	1861	1861
q18	8581	8242	8190	8190
q19	1741	1730	1730	1730
q20	2265	1949	1946	1946
q21	6539	6212	6183	6183
q22	518	445	439	439
Total cold run time: 63943 ms
Total hot run time: 60836 ms

@doris-robot
Copy link

doris-robot commented Dec 21, 2023

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46 seconds
stream load tsv: 574 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17183578168 Bytes

yujun777
yujun777 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 667ae3e into apache:master Mar 15, 2024
@wm1581066 wm1581066 added dev/2.0.x usercase Important user case type label and removed dev/2.0.4 labels Mar 15, 2024
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Mar 16, 2024
@deardeng @Doris-Extras
[fix](retry) Set query encounter rpc exception default retry times to…
844a1b5 
… 3 (apache#28555)
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Mar 21, 2024
@deardeng
[fix](retry) Set query encounter rpc exception default retry times to…
3c20418 
… 3 (apache#28555)
@deardeng deardeng mentioned this pull request Mar 21, 2024
Merged
xiaokang pushed a commit that referenced this pull request Mar 21, 2024
@deardeng
[fix](retry) Set query encounter rpc exception default retry times to…
11f616f 
… 3 (#28555) (#32593)
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@deardeng
[fix](retry) Set query encounter rpc exception default retry times to…
c5dd853 
… 3 (apache#28555) (apache#32593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deardeng @doris-robot @yujun777 @dataroaring @xiaokang @wm1581066