Skip to content

[fix](stacktrace) ignore stacktrace for error code INVERTED_INDEX_NOT_IMPLEMENTED #28598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Dec 19, 2023
Merged

[fix](stacktrace) ignore stacktrace for error code INVERTED_INDEX_NOT_IMPLEMENTED #28598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions be/src/common/status.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,10 @@ namespace ErrorCode {
E(INVERTED_INDEX_RENAME_FILE_FAILED, -6006, true); \
E(INVERTED_INDEX_EVALUATE_SKIPPED, -6007, false); \
E(INVERTED_INDEX_BUILD_WAITTING, -6008, false); \
E(KEY_NOT_FOUND, -6009, false); \
E(KEY_ALREADY_EXISTS, -6010, false); \
E(ENTRY_NOT_FOUND, -6011, false);
E(INVERTED_INDEX_NOT_IMPLEMENTED, -6009, false); \
E(KEY_NOT_FOUND, -7000, false); \
E(KEY_ALREADY_EXISTS, -7001, false); \
E(ENTRY_NOT_FOUND, -7002, false);

// Define constexpr int error_code_name = error_code_value
#define M(NAME, ERRORCODE, ENABLESTACKTRACE) constexpr int NAME = ERRORCODE;
Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/block_column_predicate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ void AndBlockColumnPredicate::evaluate_vec(vectorized::MutableColumns& block, ui
Status AndBlockColumnPredicate::evaluate(const std::string& column_name,
InvertedIndexIterator* iterator, uint32_t num_rows,
roaring::Roaring* bitmap) const {
return Status::NotSupported(
return Status::Error<ErrorCode::INVERTED_INDEX_NOT_IMPLEMENTED>(
"Not Implemented evaluate with inverted index, please check the predicate");
}

Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/block_column_predicate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ class BlockColumnPredicate {
//evaluate predicate on inverted
virtual Status evaluate(const std::string& column_name, InvertedIndexIterator* iterator,
uint32_t num_rows, roaring::Roaring* bitmap) const {
return Status::NotSupported(
return Status::Error<ErrorCode::INVERTED_INDEX_NOT_IMPLEMENTED>(
"Not Implemented evaluate with inverted index, please check the predicate");
}
};
Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/rowset/segment_v2/segment_iterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ Status SegmentIterator::_apply_inverted_index_on_block_column_predicate(
return res;
} else {
//TODO:mock until AndBlockColumnPredicate evaluate is ok.
if (res.code() == ErrorCode::NOT_IMPLEMENTED_ERROR) {
if (res.code() == ErrorCode::INVERTED_INDEX_NOT_IMPLEMENTED) {
return Status::OK();
}
LOG(WARNING) << "failed to evaluate index"
Expand Down