[Feature](datatype) update be ut codes and opt datatype for IPv4/v6 #28648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| class FunctionIsIPv4String : public IFunction { | ||
| private: | ||
| Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) const { |
Contributor
There was a problem hiding this comment.
warning: method 'execute_type' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) const { | |
| static Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) { |
|
|
||
| size_t get_number_of_arguments() const override { return 1; } | ||
|
|
||
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
Contributor
There was a problem hiding this comment.
warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
Suggested change
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { | |
| static DataTypePtr get_return_type_impl(const DataTypes& arguments) override { |
|
|
||
| class FunctionIsIPv6String : public IFunction { | ||
| private: | ||
| Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) const { |
Contributor
There was a problem hiding this comment.
warning: method 'execute_type' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) const { | |
| static Status execute_type(Block& block, const ColumnWithTypeAndName& argument, size_t result) { |
|
|
||
| size_t get_number_of_arguments() const override { return 1; } | ||
|
|
||
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
Contributor
There was a problem hiding this comment.
warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
Suggested change
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { | |
| static DataTypePtr get_return_type_impl(const DataTypes& arguments) override { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
update
from_string_testbe ut based on issue #26534output:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...