Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Dec 21, 2023

Proposed changes

reverts the optimization for delete sign on MOW table
pick from master: #26721

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@bobhan1 bobhan1 force-pushed the branch-2.0-revert-delete-sign-optimzation branch from 591417d to 0ee3cff Compare December 21, 2023 08:25
@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 21, 2023

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.78% (7989/21144)
Line Coverage: 29.49% (64905/220074)
Region Coverage: 28.96% (33387/115296)
Branch Coverage: 24.83% (17128/68988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0ee3cffa4e4db5c853f107c0dcf08ed83f4320db_0ee3cffa4e4db5c853f107c0dcf08ed83f4320db/report/index.html

@bobhan1
Copy link
Contributor Author

bobhan1 commented Dec 21, 2023

run clickbench

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.35 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 30.5 seconds inserted 10000000 Rows, about 327K ops/s
storage size: 17167883150 Bytes

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 30934ff into apache:branch-2.0 Dec 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants