Skip to content

[nereids] fix join fd computing bug #28849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 2 commits into from
Dec 23, 2023
Merged

[nereids] fix join fd computing bug #28849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b85286
[nereids] fix join fd computing bug
Dec 22, 2023
379185e
[nereids] fix join fd computing bug
Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,8 @@ public FunctionalDependencies computeFuncDeps(Supplier<List<Slot>> outputSupplie
// TODO: consider Null-safe hash condition when left and rigth is not nullable
boolean isLeftUnique = left().getLogicalProperties()
.getFunctionalDependencies().isUnique(keys.first);
boolean isRightUnique = left().getLogicalProperties()
.getFunctionalDependencies().isUnique(keys.first);
boolean isRightUnique = right().getLogicalProperties()
.getFunctionalDependencies().isUnique(keys.second);
Builder fdBuilder = new Builder();
if (joinType.isInnerJoin()) {
// inner join propagate uniforms slots
Expand Down
6 changes: 4 additions & 2 deletions fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/EliminateJoinByFkTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ void testNullWithPredicate() throws Exception {

@Test
void testMultiJoin() throws Exception {
addConstraint("Alter table foreign_null add constraint uk unique (id3)\n");
addConstraint("Alter table foreign_null add constraint uk_id3 unique (id3)\n");
addConstraint("Alter table foreign_not_null add constraint uk_id2 unique (id2)\n");
String sql = "select id1 from "
+ "foreign_null inner join foreign_not_null on id2 = id3\n"
+ "inner join pri on id1 = id3";
Expand All @@ -116,6 +117,7 @@ void testMultiJoin() throws Exception {
.rewrite()
.nonMatch(logicalOlapScan().when(scan -> scan.getTable().getName().equals("pri")))
.printlnTree();
dropConstraint("Alter table foreign_null drop constraint uk\n");
dropConstraint("Alter table foreign_null drop constraint uk_id3\n");
dropConstraint("Alter table foreign_not_null drop constraint uk_id2");
}
}