Skip to content

[fix](segcompaction) disable segcompaction by default temporarily to avoid load long tail latency #28906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 2 commits into from
Dec 22, 2023
Merged

[fix](segcompaction) disable segcompaction by default temporarily to avoid load long tail latency #28906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de4ee21
[fix](segcompaction) disable segcompaction by default
freemandealer Dec 22, 2023
89b87d4
Merge branch 'master' into segcompaction-off-by-default
freemandealer Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/common/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ DEFINE_String(be_node_role, "mix");
// Hide the be config page for webserver.
DEFINE_Bool(hide_webserver_config_page, "false");

DEFINE_Bool(enable_segcompaction, "true");
DEFINE_Bool(enable_segcompaction, "false");

// Max number of segments allowed in a single segcompaction task.
DEFINE_Int32(segcompaction_batch_size, "10");
Expand Down
2 changes: 1 addition & 1 deletion docs/en/docs/admin-manual/config/be-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ BaseCompaction:546859:

* Type: bool
* Description: Enable to use segment compaction during loading to avoid -238 error
* Default value: true
* Default value: false

#### `segcompaction_batch_size`

Expand Down
2 changes: 1 addition & 1 deletion docs/zh-CN/docs/admin-manual/config/be-config.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ BaseCompaction:546859:

* 类型：bool
* 描述：在导入时进行 segment compaction 来减少 segment 数量, 以避免出现写入时的 -238 错误
* 默认值：true
* 默认值：false

#### `segcompaction_batch_size`

Expand Down