Skip to content

[opt](Nereids) support cast bewteen numeric and boolean in FE #29006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Dec 26, 2023
Merged

[opt](Nereids) support cast bewteen numeric and boolean in FE #29006

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 23 additions & 6 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/Literal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,15 +185,15 @@ public Expression checkedCastTo(DataType targetType) throws AnalysisException {
minVal = new BigDecimal(LargeIntType.MIN_VALUE);
} else if (targetType.isFloatType()) {
maxVal = new BigDecimal(Float.MAX_VALUE);
minVal = new BigDecimal(-Float.MAX_VALUE);
minVal = BigDecimal.valueOf(-Float.MAX_VALUE);
} else if (targetType.isDoubleType()) {
maxVal = new BigDecimal(Double.MAX_VALUE);
minVal = new BigDecimal(-Double.MAX_VALUE);
minVal = BigDecimal.valueOf(-Double.MAX_VALUE);
}

if (val.compareTo(maxVal) > 0 || val.compareTo(minVal) < 0) {
throw new AnalysisException(
String.format("{} can't cast to {}", desc, targetType));
String.format("%s can't cast to %s", desc, targetType));
}
}
return uncheckedCastTo(targetType);
Expand All @@ -209,7 +209,24 @@ protected Expression uncheckedCastTo(DataType targetType) throws AnalysisExcepti
}
// TODO support string to complex
String desc = getStringValue();
// convert boolean to byte string value to support cast boolean to numeric in FE.
if (this.equals(BooleanLiteral.TRUE)) {
desc = "1";
} else if (this.equals(BooleanLiteral.FALSE)) {
desc = "0";
}
if (targetType.isBooleanType()) {
try {
// convert any non-zero numeric literal to true if target type is boolean
long value = Long.parseLong(desc);
if (value == 0) {
return Literal.of(false);
} else {
return Literal.of(true);
}
} catch (Exception e) {
// ignore
}
if ("0".equals(desc) || "false".equals(desc.toLowerCase(Locale.ROOT))) {
return Literal.of(false);
}
Expand All @@ -218,11 +235,11 @@ protected Expression uncheckedCastTo(DataType targetType) throws AnalysisExcepti
}
}
if (targetType.isTinyIntType()) {
return Literal.of(Byte.valueOf(desc).byteValue());
return Literal.of(Byte.valueOf(desc));
} else if (targetType.isSmallIntType()) {
return Literal.of(Short.valueOf(desc).shortValue());
return Literal.of(Short.valueOf(desc));
} else if (targetType.isIntegerType()) {
return Literal.of(Integer.valueOf(desc).intValue());
return Literal.of(Integer.valueOf(desc));
} else if (targetType.isBigIntType()) {
return Literal.of(Long.valueOf(desc));
} else if (targetType.isLargeIntType()) {
Expand Down