Skip to content

Conversation

@caiconghui
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…t row size between columns in origin block (#28850)

Co-authored-by: caiconghui1 <caiconghui1@jd.com>
@caiconghui
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8005/21175)
Line Coverage: 29.48% (65018/220556)
Region Coverage: 28.97% (33472/115543)
Branch Coverage: 24.85% (17182/69156)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42f916c7e1b5a6c1b8e01c6a8f9a9d093271c8c2_42f916c7e1b5a6c1b8e01c6a8f9a9d093271c8c2/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.82 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17168242388 Bytes

@caiconghui caiconghui added dev/2.0.4 kind/fix Categorizes issue or PR as related to a bug. labels Dec 27, 2023
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 27, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang xiaokang merged commit 2efec46 into branch-2.0 Dec 28, 2023
@xiaokang
Copy link
Contributor

#28850

@xiaokang
Copy link
Contributor

#27943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants