Skip to content

Conversation

@liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx
pick from #29386

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

PR approved by anyone and no changes requested.

@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 51.22 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 22 seconds loaded 2358488459 Bytes, about 102 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.6 seconds inserted 10000000 Rows, about 337K ops/s
storage size: 17163262197 Bytes

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8020/21193)
Line Coverage: 29.53% (65258/220994)
Region Coverage: 28.97% (33543/115774)
Branch Coverage: 24.83% (17210/69320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/754bc2a287778a3a380b6e4ba7b17afbb581d184_754bc2a287778a3a380b6e4ba7b17afbb581d184/report/index.html

@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (8018/21193)
Line Coverage: 29.52% (65232/220994)
Region Coverage: 28.96% (33524/115774)
Branch Coverage: 24.81% (17201/69320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/754bc2a287778a3a380b6e4ba7b17afbb581d184_754bc2a287778a3a380b6e4ba7b17afbb581d184/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.35 seconds
stream load tsv: 563 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162434109 Bytes

@liaoxin01
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (8018/21193)
Line Coverage: 29.52% (65229/220994)
Region Coverage: 28.96% (33525/115774)
Branch Coverage: 24.82% (17202/69320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/20e37f26d114c0c67f82eb831cf4ba6f8aaaf3de_20e37f26d114c0c67f82eb831cf4ba6f8aaaf3de/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.99 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 30.1 seconds inserted 10000000 Rows, about 332K ops/s
storage size: 17162598968 Bytes

@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (8018/21193)
Line Coverage: 29.52% (65235/220996)
Region Coverage: 28.96% (33523/115774)
Branch Coverage: 24.81% (17201/69320)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a5c625f632c719438a976432b166c8e7d94a0c13_a5c625f632c719438a976432b166c8e7d94a0c13/report/index.html

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.36 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.8 seconds inserted 10000000 Rows, about 335K ops/s
storage size: 17162661918 Bytes

@dataroaring dataroaring merged commit 10b9205 into apache:branch-2.0 Jan 7, 2024
@liaoxin01 liaoxin01 deleted the cherry_pick_29386 branch February 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants