[fix](kerberos) optimize kerbero options, remove BE kinit, just use UGI login by newInstanceFromKeytab #29291 #29922
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| private: | ||
| FileHandleCache _cache; | ||
| HdfsFileHandleCache() : _cache(config::max_hdfs_file_handle_cache_num, 16, 3600 * 1000L) {} | ||
| HdfsFileHandleCache() |
There was a problem hiding this comment.
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
be/src/io/fs/hdfs_file_system.cpp:107:
- config::max_hdfs_file_handle_cache_time_sec * 1000L) {};
+ config::max_hdfs_file_handle_cache_time_sec * 1000L) = default;;| hdfsBuilder* get() { return hdfs_builder; } | ||
| bool is_need_kinit() const { return need_kinit; } | ||
| Status run_kinit(); | ||
| bool is_kerberos() const { return kerberos_login; } |
There was a problem hiding this comment.
warning: function 'is_kerberos' should be marked [[nodiscard]] [modernize-use-nodiscard]
| bool is_kerberos() const { return kerberos_login; } | |
| [[nodiscard]] bool is_kerberos() const { return kerberos_login; } |
morningman
changed the title
|
run buildall |
|
TeamCity be ut coverage result: |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
4 participants
Proposed changes
from #29291
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...