Skip to content

[function](char) change char function behaviour same with mysql #30034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Jan 17, 2024
Merged

[function](char) change char function behaviour same with mysql #30034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/vec/functions/function_string.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3243,7 +3243,7 @@ class FunctionIntToChar : public IFunction {
void integer_to_char_(int line_num, const int* num, ColumnString::Chars& chars,
IColumn::Offsets& offsets) const {
if (0 == *num) {
chars.push_back(' ');
chars.push_back('\0');
offsets[line_num] = offsets[line_num - 1] + 1;
return;
}
Expand All @@ -3257,7 +3257,7 @@ class FunctionIntToChar : public IFunction {
}
offsets[line_num] = offsets[line_num - 1] + k + 1;
for (; k >= 0; --k) {
chars.push_back(bytes[k] ? bytes[k] : ' ');
chars.push_back(bytes[k] ? bytes[k] : '\0');
}
#else
int k = 0;
Expand All @@ -3268,7 +3268,7 @@ class FunctionIntToChar : public IFunction {
}
offsets[line_num] = offsets[line_num - 1] + 4 - k;
for (; k < 4; ++k) {
chars.push_back(bytes[k] ? bytes[k] : ' ');
chars.push_back(bytes[k] ? bytes[k] : '\0');
}
#endif
}
Expand Down
Binary file modified regression-test/data/query_p0/sql_functions/string_functions/test_string_function.out
View file
Open in desktop
Binary file not shown.
2 changes: 2 additions & 0 deletions regression-test/suites/query_p0/sql_functions/string_functions/test_string_function.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,5 +280,7 @@ suite("test_string_function", "arrow_flight_sql") {
qt_sql_func_char6 """ select char(k1) from test_function_char order by k1; """
qt_sql_func_char7 """ select char(k1, k2, k3, k4) from test_function_char order by k1, k2, k3, k4; """
qt_sql_func_char8 """ select char(k1, k2, k3, k4, 65) from test_function_char order by k1, k2, k3, k4; """
qt_sql_func_char9 """ select char(0) = ' '; """
qt_sql_func_char10 """ select char(0) = '\0'; """

}