[fix](regex) fix wrong escape of function LIKE #30557

zclllyybb · 2024-01-30T05:54:32Z

Proposed changes

Issue Number: close #30425

before:

mysql> select 'facebook_10008_T1+T2-ALL_AAA-VO_LowestCost_20230830_HSJ' LIKE '%facebook_10008_T1+T2%';
+-------------------------------------------------------------------------------------------+
| ('facebook_10008_T1+T2-ALL_AAA-VO_LowestCost_20230830_HSJ' like '%facebook_10008_T1+T2%') |
+-------------------------------------------------------------------------------------------+
|                                                                                         0 |
+-------------------------------------------------------------------------------------------+

after:

mysql> select 'facebook_10008_T1+T2-ALL_AAA-VO_LowestCost_20230830_HSJ' LIKE '%facebook_10008_T1+T2%';
+-------------------------------------------------------------------------------------------+
| ('facebook_10008_T1+T2-ALL_AAA-VO_LowestCost_20230830_HSJ' like '%facebook_10008_T1+T2%') |
+-------------------------------------------------------------------------------------------+
|                                                                                         1 |
+-------------------------------------------------------------------------------------------+

for backslash, keep the behaviours now. not change them because it will be a huge change of string parsing.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

zclllyybb · 2024-01-30T05:56:17Z

run buildall

github-actions

clang-tidy made some suggestions

be/src/vec/functions/like.h

doris-robot · 2024-01-30T07:09:15Z

TPC-H: Total hot run time: 37098 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54208af1bbf789e33bba0696dcbd46ecf8f8cb5e, data reload: false

------ Round 1 ----------------------------------
q1	17665	4699	4521	4521
q2	2057	149	132	132
q3	10666	968	909	909
q4	4664	795	698	698
q5	7709	2842	2858	2842
q6	186	123	119	119
q7	1132	725	716	716
q8	9364	2060	2038	2038
q9	7277	6372	6346	6346
q10	8102	2422	2401	2401
q11	416	212	200	200
q12	733	283	273	273
q13	18004	3309	3303	3303
q14	264	242	249	242
q15	529	496	487	487
q16	463	407	415	407
q17	950	529	568	529
q18	6783	5969	5933	5933
q19	1553	1398	1345	1345
q20	633	332	338	332
q21	6909	3122	3028	3028
q22	817	302	297	297
Total cold run time: 106876 ms
Total hot run time: 37098 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4418	4486	4442	4442
q2	324	224	237	224
q3	3014	2865	2808	2808
q4	1884	1672	1646	1646
q5	5241	5293	5315	5293
q6	193	112	116	112
q7	2171	1780	1804	1780
q8	3123	3260	3251	3251
q9	8391	8366	8325	8325
q10	6032	3573	3568	3568
q11	540	473	452	452
q12	741	586	592	586
q13	12039	3145	3093	3093
q14	272	255	264	255
q15	554	486	491	486
q16	517	461	462	461
q17	1875	1695	1720	1695
q18	7962	7659	7600	7600
q19	9458	1544	1522	1522
q20	2149	1898	1908	1898
q21	4999	4655	4511	4511
q22	537	472	485	472
Total cold run time: 76434 ms
Total hot run time: 54480 ms

doris-robot · 2024-01-30T07:20:00Z

TPC-DS: Total hot run time: 172131 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54208af1bbf789e33bba0696dcbd46ecf8f8cb5e, data reload: false

query1	929	332	323	323
query2	6552	2059	2044	2044
query3	6693	204	197	197
query4	27422	22195	21980	21980
query5	4454	345	347	345
query6	246	152	152	152
query7	4638	258	258	258
query8	249	174	174	174
query9	9001	2288	2263	2263
query10	415	196	195	195
query11	16066	15353	15257	15257
query12	120	67	64	64
query13	1685	368	370	368
query14	9274	6582	6509	6509
query15	211	177	177	177
query16	6296	247	247	247
query17	1884	481	461	461
query18	1811	256	266	256
query19	169	125	132	125
query20	72	69	67	67
query21	205	127	129	127
query22	4888	4770	4636	4636
query23	31083	30227	30324	30227
query24	7273	2705	2734	2705
query25	544	304	301	301
query26	853	135	144	135
query27	2800	289	279	279
query28	5206	1825	1817	1817
query29	917	610	607	607
query30	277	137	136	136
query31	893	698	704	698
query32	88	51	49	49
query33	440	209	211	209
query34	825	454	465	454
query35	863	741	767	741
query36	1264	1202	1151	1151
query37	91	56	55	55
query38	3238	3216	3147	3147
query39	1283	1252	1248	1248
query40	187	88	78	78
query41	37	34	33	33
query42	91	80	81	80
query43	533	498	504	498
query44	1060	678	680	678
query45	207	179	171	171
query46	1036	628	613	613
query47	1580	1537	1491	1491
query48	388	323	297	297
query49	1110	275	280	275
query50	690	294	297	294
query51	5316	5158	5156	5156
query52	90	73	68	68
query53	308	264	254	254
query54	215	181	180	180
query55	84	76	71	71
query56	185	155	160	155
query57	958	882	902	882
query58	184	151	149	149
query59	2494	2370	2462	2370
query60	196	174	178	174
query61	84	88	80	80
query62	616	352	358	352
query63	266	262	261	261
query64	3949	1754	1745	1745
query65	3293	3265	3219	3219
query66	1140	323	312	312
query67	14435	13989	14050	13989
query68	3882	484	488	484
query69	436	290	288	288
query70	1563	1454	1521	1454
query71	270	208	225	208
query72	3641	2842	2834	2834
query73	682	315	315	315
query74	6564	6310	6242	6242
query75	2802	2288	2268	2268
query76	2939	985	875	875
query77	355	231	217	217
query78	9029	8751	8534	8534
query79	2314	498	482	482
query80	1439	313	301	301
query81	492	194	195	194
query82	659	82	76	76
query83	213	115	112	112
query84	231	77	75	75
query85	1670	332	325	325
query86	508	416	407	407
query87	3407	3231	3270	3231
query88	3688	2144	2187	2144
query89	427	339	344	339
query90	1906	182	177	177
query91	153	114	115	114
query92	55	44	46	44
query93	2268	442	423	423
query94	1251	159	156	156
query95	504	451	451	451
query96	609	318	313	313
query97	4247	4080	4123	4080
query98	208	196	185	185
query99	1059	738	674	674
Total cold run time: 261421 ms
Total hot run time: 172131 ms

doris-robot · 2024-01-30T07:25:25Z

ClickBench: Total hot run time: 30.36 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54208af1bbf789e33bba0696dcbd46ecf8f8cb5e, data reload: false

query1	0.04	0.03	0.04
query2	0.06	0.02	0.02
query3	0.23	0.06	0.06
query4	1.66	0.10	0.09
query5	0.53	0.53	0.52
query6	1.20	0.65	0.65
query7	0.02	0.01	0.01
query8	0.04	0.02	0.03
query9	0.54	0.52	0.50
query10	0.57	0.55	0.55
query11	0.12	0.09	0.09
query12	0.11	0.08	0.09
query13	0.59	0.61	0.60
query14	0.81	0.78	0.81
query15	0.80	0.78	0.77
query16	0.38	0.38	0.38
query17	1.03	1.01	1.04
query18	0.22	0.26	0.25
query19	1.87	1.75	1.80
query20	0.02	0.01	0.01
query21	15.40	0.57	0.57
query22	2.30	2.08	1.95
query23	17.40	0.75	0.75
query24	2.95	0.86	0.13
query25	0.20	0.24	0.14
query26	0.44	0.14	0.14
query27	0.05	0.05	0.05
query28	12.87	0.84	0.83
query29	12.54	3.28	3.23
query30	0.63	0.59	0.53
query31	2.79	0.34	0.36
query32	3.36	0.47	0.48
query33	3.18	3.25	3.25
query34	15.78	4.36	4.23
query35	4.32	4.26	4.32
query36	1.11	1.05	1.05
query37	0.06	0.05	0.05
query38	0.03	0.03	0.03
query39	0.02	0.02	0.01
query40	0.17	0.13	0.14
query41	0.07	0.01	0.01
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.57 s
Total hot run time: 30.36 s

be/src/udf/udf.h

be/src/vec/functions/like.cpp

doris-robot · 2024-01-30T07:27:25Z

TeamCity be ut coverage result:
Function Coverage: 36.20% (8627/23829)
Line Coverage: 28.26% (70553/249626)
Region Coverage: 27.28% (36431/133547)
Branch Coverage: 24.08% (18673/77556)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54208af1bbf789e33bba0696dcbd46ecf8f8cb5e_54208af1bbf789e33bba0696dcbd46ecf8f8cb5e/report/index.html

doris-robot · 2024-01-30T07:28:29Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 54208af1bbf789e33bba0696dcbd46ecf8f8cb5e with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       14.2 seconds inserted 10000000 Rows, about 704K ops/s

zclllyybb · 2024-01-30T09:04:24Z

run buildall

doris-robot · 2024-01-30T09:43:32Z

TPC-H: Total hot run time: 36829 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 143b9b09d9cf654158410c6c4cc0aeca7fbf4395, data reload: false

------ Round 1 ----------------------------------
q1	17633	4597	4366	4366
q2	2035	139	126	126
q3	10606	914	944	914
q4	4646	719	731	719
q5	7687	2836	2842	2836
q6	187	121	118	118
q7	1118	730	707	707
q8	9321	2014	2017	2014
q9	7263	6306	6310	6306
q10	8107	2434	2402	2402
q11	419	202	212	202
q12	727	278	288	278
q13	18024	3339	3304	3304
q14	282	250	256	250
q15	549	495	485	485
q16	468	408	406	406
q17	925	563	546	546
q18	6785	5926	5817	5817
q19	1576	1391	1379	1379
q20	586	360	329	329
q21	6853	3099	3038	3038
q22	787	300	287	287
Total cold run time: 106584 ms
Total hot run time: 36829 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4642	4397	4473	4397
q2	333	240	240	240
q3	3025	2816	2792	2792
q4	1886	1745	1682	1682
q5	5179	5255	5220	5220
q6	193	115	114	114
q7	2154	1736	1762	1736
q8	3103	3246	3253	3246
q9	8294	8328	8275	8275
q10	5816	3536	3544	3536
q11	543	447	448	447
q12	744	567	558	558
q13	11952	3110	3082	3082
q14	278	249	263	249
q15	545	491	486	486
q16	508	458	466	458
q17	1871	1698	1635	1635
q18	8077	7718	7635	7635
q19	9153	1561	1499	1499
q20	2114	1921	1930	1921
q21	4756	4467	4583	4467
q22	541	446	475	446
Total cold run time: 75707 ms
Total hot run time: 54121 ms

doris-robot · 2024-01-30T09:54:22Z

TPC-DS: Total hot run time: 172065 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 143b9b09d9cf654158410c6c4cc0aeca7fbf4395, data reload: false

query1	936	332	326	326
query2	6558	1968	1962	1962
query3	6701	199	192	192
query4	27269	22164	22041	22041
query5	4446	342	354	342
query6	249	163	155	155
query7	4605	265	253	253
query8	254	179	175	175
query9	9056	2294	2277	2277
query10	421	193	195	193
query11	16592	15323	15382	15323
query12	118	68	65	65
query13	1671	372	374	372
query14	9198	6505	6431	6431
query15	221	180	189	180
query16	6472	252	250	250
query17	1909	483	457	457
query18	1927	258	250	250
query19	168	131	129	129
query20	69	70	65	65
query21	193	135	119	119
query22	4907	4736	4641	4641
query23	31109	30320	30163	30163
query24	10195	2794	2766	2766
query25	531	294	304	294
query26	821	138	137	137
query27	2857	281	284	281
query28	6126	1838	1825	1825
query29	934	624	589	589
query30	280	133	138	133
query31	915	688	699	688
query32	91	51	50	50
query33	583	210	206	206
query34	817	454	464	454
query35	820	743	772	743
query36	1273	1145	1216	1145
query37	92	59	60	59
query38	3248	3175	3102	3102
query39	1304	1247	1247	1247
query40	190	90	80	80
query41	38	39	35	35
query42	87	82	85	82
query43	515	481	490	481
query44	1052	673	683	673
query45	192	178	175	175
query46	1057	625	626	625
query47	1619	1475	1467	1467
query48	398	306	304	304
query49	1109	280	274	274
query50	658	310	317	310
query51	5241	5121	5193	5121
query52	99	73	78	73
query53	329	256	252	252
query54	236	180	180	180
query55	80	72	73	72
query56	179	159	165	159
query57	960	918	891	891
query58	181	154	156	154
query59	2421	2280	2300	2280
query60	192	181	166	166
query61	82	85	82	82
query62	633	325	342	325
query63	292	263	258	258
query64	3996	1751	1721	1721
query65	3269	3218	3206	3206
query66	1126	317	312	312
query67	14395	14074	14117	14074
query68	3998	498	491	491
query69	439	310	318	310
query70	1480	1485	1512	1485
query71	280	210	228	210
query72	3703	2812	2820	2812
query73	686	318	312	312
query74	6472	6270	6249	6249
query75	2773	2276	2254	2254
query76	2939	961	972	961
query77	362	233	233	233
query78	9095	8596	8481	8481
query79	2531	498	494	494
query80	1967	315	316	315
query81	541	198	201	198
query82	705	82	82	82
query83	242	114	113	113
query84	283	74	70	70
query85	2012	336	310	310
query86	498	386	367	367
query87	3435	3312	3259	3259
query88	3724	2169	2163	2163
query89	415	354	348	348
query90	1906	183	179	179
query91	143	111	122	111
query92	50	41	44	41
query93	2355	443	434	434
query94	1248	160	158	158
query95	494	454	450	450
query96	631	308	313	308
query97	4270	4103	4149	4103
query98	208	187	185	185
query99	998	667	686	667
Total cold run time: 267445 ms
Total hot run time: 172065 ms

doris-robot · 2024-01-30T09:59:48Z

ClickBench: Total hot run time: 30.87 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 143b9b09d9cf654158410c6c4cc0aeca7fbf4395, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.02	0.03
query3	0.23	0.06	0.06
query4	1.68	0.10	0.10
query5	0.53	0.52	0.51
query6	1.19	0.66	0.67
query7	0.02	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.48	0.48
query10	0.57	0.55	0.56
query11	0.11	0.08	0.08
query12	0.11	0.09	0.10
query13	0.62	0.62	0.59
query14	0.79	0.82	0.80
query15	0.80	0.79	0.78
query16	0.37	0.38	0.37
query17	1.01	0.98	1.02
query18	0.22	0.25	0.24
query19	1.92	1.78	1.74
query20	0.01	0.01	0.01
query21	15.40	0.55	0.58
query22	2.84	2.72	1.97
query23	17.38	0.82	0.75
query24	2.24	0.73	0.92
query25	0.35	0.22	0.17
query26	0.47	0.15	0.14
query27	0.05	0.06	0.04
query28	12.02	0.86	0.84
query29	12.57	3.28	3.17
query30	0.60	0.51	0.55
query31	2.78	0.35	0.35
query32	3.36	0.48	0.47
query33	3.22	3.19	3.18
query34	15.92	4.26	4.31
query35	4.28	4.32	4.40
query36	1.11	1.04	1.05
query37	0.06	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.01	0.02
query40	0.15	0.13	0.13
query41	0.07	0.01	0.02
query42	0.02	0.01	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.83 s
Total hot run time: 30.87 s

doris-robot · 2024-01-30T10:02:51Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 143b9b09d9cf654158410c6c4cc0aeca7fbf4395 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

doris-robot · 2024-01-30T10:28:00Z

TeamCity be ut coverage result:
Function Coverage: 36.20% (8627/23829)
Line Coverage: 28.27% (70558/249625)
Region Coverage: 27.28% (36431/133547)
Branch Coverage: 24.07% (18668/77556)
Coverage Report: http://coverage.selectdb-in.cc/coverage/143b9b09d9cf654158410c6c4cc0aeca7fbf4395_143b9b09d9cf654158410c6c4cc0aeca7fbf4395/report/index.html

zclllyybb · 2024-01-30T15:40:55Z

run feut

regression-test/suites/query_p0/sql_functions/conditional_functions/test_query_like.groovy

be/src/vec/functions/like.cpp

zclllyybb · 2024-01-31T04:51:17Z

run buildall

doris-robot · 2024-01-31T06:14:24Z

TeamCity be ut coverage result:
Function Coverage: 36.20% (8628/23836)
Line Coverage: 28.26% (70560/249714)
Region Coverage: 27.26% (36429/133623)
Branch Coverage: 24.05% (18660/77592)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dbbbdfdc534c953c0d1f7b40090f981c97652047_dbbbdfdc534c953c0d1f7b40090f981c97652047/report/index.html

HappenLee · 2024-02-04T06:33:37Z

move case to UT

zclllyybb · 2024-02-06T00:08:54Z

run buildall

doris-robot · 2024-02-06T01:38:45Z

TeamCity be ut coverage result:
Function Coverage: 36.19% (8632/23850)
Line Coverage: 28.20% (70539/250130)
Region Coverage: 27.24% (36432/133739)
Branch Coverage: 24.01% (18664/77740)
Coverage Report: http://coverage.selectdb-in.cc/coverage/37eecb7057389e2cbd090eec9ea106c7ba8d8bec_37eecb7057389e2cbd090eec9ea106c7ba8d8bec/report/index.html

zclllyybb · 2024-02-07T07:47:52Z

run buildall

github-actions · 2024-02-07T07:56:35Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-02-07T08:07:02Z

TPC-H: Total hot run time: 37576 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e45d312d4122b36ba599109b3a8a973023e7ce79, data reload: false

------ Round 1 ----------------------------------
q1	17833	4585	4541	4541
q2	2389	160	138	138
q3	11456	950	939	939
q4	4862	796	783	783
q5	7766	3004	2947	2947
q6	191	127	126	126
q7	1180	762	733	733
q8	9324	2065	2054	2054
q9	7933	6363	6331	6331
q10	8117	2414	2403	2403
q11	410	204	210	204
q12	814	290	289	289
q13	18013	3368	3322	3322
q14	281	259	240	240
q15	527	496	488	488
q16	471	410	417	410
q17	950	594	516	516
q18	6754	5998	6082	5998
q19	1558	1412	1389	1389
q20	644	343	341	341
q21	6728	3075	3137	3075
q22	815	309	312	309
Total cold run time: 109016 ms
Total hot run time: 37576 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4494	4453	4412	4412
q2	326	227	232	227
q3	2953	2822	2799	2799
q4	1891	1640	1684	1640
q5	5199	5192	5231	5192
q6	191	114	115	114
q7	2099	1783	1792	1783
q8	3147	3294	3254	3254
q9	8324	8287	8239	8239
q10	5848	3530	3559	3530
q11	551	458	474	458
q12	761	592	575	575
q13	5122	3098	3071	3071
q14	275	236	257	236
q15	527	480	493	480
q16	541	473	473	473
q17	1851	1721	1732	1721
q18	8082	7657	7491	7491
q19	6830	1521	1531	1521
q20	2133	1935	1897	1897
q21	4866	4691	4565	4565
q22	537	474	470	470
Total cold run time: 66548 ms
Total hot run time: 54148 ms

doris-robot · 2024-02-07T08:15:58Z

TeamCity be ut coverage result:
Function Coverage: 36.17% (8638/23882)
Line Coverage: 28.20% (70628/250479)
Region Coverage: 27.20% (36467/134080)
Branch Coverage: 23.98% (18676/77890)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e45d312d4122b36ba599109b3a8a973023e7ce79_e45d312d4122b36ba599109b3a8a973023e7ce79/report/index.html

doris-robot · 2024-02-07T08:18:31Z

TPC-DS: Total hot run time: 173612 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e45d312d4122b36ba599109b3a8a973023e7ce79, data reload: false

query1	923	341	333	333
query2	6548	1927	2008	1927
query3	6708	209	202	202
query4	31611	21987	21935	21935
query5	4283	369	363	363
query6	251	158	166	158
query7	4615	282	280	280
query8	265	174	181	174
query9	9053	2238	2219	2219
query10	421	209	214	209
query11	19006	15246	15317	15246
query12	132	75	73	73
query13	1632	418	419	418
query14	9507	7047	7118	7047
query15	264	181	179	179
query16	8147	271	249	249
query17	2054	537	490	490
query18	2102	269	262	262
query19	362	141	140	140
query20	83	87	77	77
query21	202	123	115	115
query22	4805	4562	4603	4562
query23	31718	29981	29948	29948
query24	11160	2759	2771	2759
query25	575	338	336	336
query26	1711	149	148	148
query27	2921	294	310	294
query28	7397	1847	1800	1800
query29	964	633	604	604
query30	282	131	140	131
query31	928	693	719	693
query32	97	59	50	50
query33	729	221	225	221
query34	1091	462	461	461
query35	916	743	731	731
query36	1020	934	932	932
query37	115	56	57	56
query38	3260	3136	3066	3066
query39	1319	1263	1240	1240
query40	265	92	92	92
query41	36	35	34	34
query42	96	92	89	89
query43	529	509	495	495
query44	1148	675	692	675
query45	186	180	175	175
query46	1056	663	659	659
query47	1611	1472	1467	1467
query48	418	351	353	351
query49	1181	291	286	286
query50	760	389	377	377
query51	5271	5216	5102	5102
query52	104	94	86	86
query53	332	268	261	261
query54	276	207	220	207
query55	83	75	75	75
query56	224	206	203	203
query57	1007	904	903	903
query58	208	173	187	173
query59	2493	2453	2339	2339
query60	236	210	208	208
query61	83	84	90	84
query62	639	346	362	346
query63	293	269	263	263
query64	6390	3472	3197	3197
query65	3228	3228	3218	3218
query66	1072	313	306	306
query67	14197	13921	14247	13921
query68	4313	535	537	535
query69	464	335	331	331
query70	1272	1232	1237	1232
query71	320	243	252	243
query72	5980	2842	2633	2633
query73	707	331	326	326
query74	6519	6181	6200	6181
query75	3047	2305	2324	2305
query76	2549	913	887	887
query77	455	233	222	222
query78	9193	8781	8584	8584
query79	2767	485	490	485
query80	2038	353	345	345
query81	540	197	196	196
query82	796	85	79	79
query83	245	120	128	120
query84	298	84	79	79
query85	2277	346	321	321
query86	491	311	298	298
query87	3362	3211	3183	3183
query88	3834	2362	2372	2362
query89	439	367	351	351
query90	2130	164	166	164
query91	156	118	123	118
query92	63	45	42	42
query93	2715	498	492	492
query94	1385	177	172	172
query95	8123	7849	358	358
query96	588	281	276	276
query97	4215	4104	4092	4092
query98	222	198	190	190
query99	1061	690	697	690
Total cold run time: 295163 ms
Total hot run time: 173612 ms

doris-robot · 2024-02-07T08:24:00Z

ClickBench: Total hot run time: 30.91 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e45d312d4122b36ba599109b3a8a973023e7ce79, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.24	0.06	0.05
query4	1.65	0.10	0.10
query5	0.54	0.52	0.52
query6	1.20	0.64	0.63
query7	0.01	0.01	0.01
query8	0.04	0.03	0.02
query9	0.56	0.50	0.50
query10	0.55	0.54	0.56
query11	0.12	0.08	0.08
query12	0.11	0.08	0.09
query13	0.60	0.61	0.61
query14	0.78	0.80	0.82
query15	0.78	0.78	0.77
query16	0.38	0.38	0.38
query17	1.04	1.04	1.00
query18	0.22	0.27	0.24
query19	1.92	1.80	1.74
query20	0.01	0.00	0.01
query21	15.43	0.58	0.55
query22	2.77	2.34	2.30
query23	17.43	0.79	0.85
query24	2.51	0.56	1.40
query25	0.31	0.19	0.09
query26	0.51	0.15	0.14
query27	0.05	0.06	0.06
query28	12.71	0.84	0.83
query29	12.50	3.29	3.09
query30	0.60	0.53	0.56
query31	2.78	0.35	0.36
query32	3.33	0.47	0.48
query33	3.15	3.25	3.17
query34	16.04	4.25	4.25
query35	4.29	4.30	4.31
query36	1.10	1.04	1.04
query37	0.07	0.05	0.05
query38	0.04	0.03	0.02
query39	0.02	0.02	0.01
query40	0.17	0.13	0.13
query41	0.07	0.01	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 106.79 s
Total hot run time: 30.91 s

doris-robot · 2024-02-07T08:27:09Z

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit e45d312d4122b36ba599109b3a8a973023e7ce79 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       13.9 seconds inserted 10000000 Rows, about 719K ops/s

HappenLee

LGTM

github-actions · 2024-02-07T22:05:57Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-02-07T22:05:59Z

PR approved by anyone and no changes requested.

fix wrong escape of function LIKE

Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

fix wrong escape of function LIKE

…#30987) Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

zclllyybb changed the title ~~[Enhancement] Support NO_BACKSLASH_ESCAPES on BE and fix result~~ [Enhancement](regex) Support NO_BACKSLASH_ESCAPES on BE and fix result Jan 30, 2024

github-actions bot added the meta-change label Jan 30, 2024

BiteTheDDDDt added the p0_w label Jan 30, 2024

github-actions bot reviewed Jan 30, 2024

View reviewed changes

be/src/vec/functions/like.h Show resolved Hide resolved

zhiqiang-hhhh reviewed Jan 30, 2024

View reviewed changes

xiaokang added the dev/2.0.5 label Jan 30, 2024

zhiqiang-hhhh reviewed Jan 31, 2024

View reviewed changes

regression-test/suites/query_p0/sql_functions/conditional_functions/test_query_like.groovy Outdated Show resolved Hide resolved

be/src/vec/functions/like.cpp Outdated Show resolved Hide resolved

zclllyybb force-pushed the fix_like branch from 53f24b0 to dbbbdfd Compare January 31, 2024 04:50

wm1581066 requested review from HappenLee and yiguolei January 31, 2024 06:31

wm1581066 added the usercase Important user case type label label Feb 1, 2024

zclllyybb force-pushed the fix_like branch from dbbbdfd to 37eecb7 Compare February 6, 2024 00:08

1

e45d312

zclllyybb force-pushed the fix_like branch from 37eecb7 to e45d312 Compare February 7, 2024 07:47

zclllyybb changed the title ~~[Enhancement](regex) Support NO_BACKSLASH_ESCAPES on BE and fix result~~ [fix](regex) fix wrong escape of function LIKE Feb 7, 2024

HappenLee approved these changes Feb 7, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2024

github-actions bot added the reviewed label Feb 7, 2024

BiteTheDDDDt approved these changes Feb 8, 2024

View reviewed changes

BiteTheDDDDt merged commit 42bb263 into apache:master Feb 8, 2024

xiaokang pushed a commit to xiaokang/doris that referenced this pull request Feb 8, 2024

[fix](regex) fix wrong escape of function LIKE (apache#30557)

24c3bba

fix wrong escape of function LIKE

xiaokang mentioned this pull request Feb 8, 2024

[fix](regex) fix wrong escape of function LIKE #30557 #30987

Merged

yiguolei pushed a commit that referenced this pull request Feb 8, 2024

[fix](regex) fix wrong escape of function LIKE (#30557)

50cb803

fix wrong escape of function LIKE

xiaokang added a commit that referenced this pull request Feb 8, 2024

[fix](regex) fix wrong escape of function LIKE (#30557) (#30987)

d72e56e

Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

xiaokang added dev/2.0.5-merged and removed dev/2.0.5 labels Feb 8, 2024

yiguolei pushed a commit that referenced this pull request Feb 16, 2024

[fix](regex) fix wrong escape of function LIKE (#30557)

d60ecdb

fix wrong escape of function LIKE

mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Feb 19, 2024

[fix](regex) fix wrong escape of function LIKE (apache#30557)

382d287

fix wrong escape of function LIKE

mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024

[fix](regex) fix wrong escape of function LIKE (apache#30557) (apache…

b3844fb

…#30987) Co-authored-by: zclllyybb <zhaochangle@selectdb.com>

[fix](regex) fix wrong escape of function LIKE #30557

[fix](regex) fix wrong escape of function LIKE #30557

Uh oh!

Conversation

zclllyybb commented Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

zclllyybb commented Jan 30, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

zclllyybb commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

doris-robot commented Jan 30, 2024

Uh oh!

zclllyybb commented Jan 30, 2024

Uh oh!

Uh oh!

Uh oh!

zclllyybb commented Jan 31, 2024

Uh oh!

doris-robot commented Jan 31, 2024

Uh oh!

HappenLee commented Feb 4, 2024

Uh oh!

zclllyybb commented Feb 6, 2024

Uh oh!

doris-robot commented Feb 6, 2024

Uh oh!

zclllyybb commented Feb 7, 2024

Uh oh!

github-actions bot commented Feb 7, 2024

Uh oh!

doris-robot commented Feb 7, 2024

Uh oh!

doris-robot commented Feb 7, 2024

Uh oh!

doris-robot commented Feb 7, 2024

Uh oh!

doris-robot commented Feb 7, 2024

Uh oh!

doris-robot commented Feb 7, 2024

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 7, 2024

Uh oh!

github-actions bot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

zclllyybb commented Jan 30, 2024 •

edited

Loading