Skip to content

[cherry-pick](char) change char function behavior same with mysql (#30034) #30628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 1 commit into from
Jan 31, 2024
Merged

[cherry-pick](char) change char function behavior same with mysql (#30034) #30628

xiaokang merged 1 commit into from
Jan 31, 2024

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jan 31, 2024

cherry-pick from master #30034

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jan 31, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jan 31, 2024

TPC-H: Total hot run time: 50139 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862, data reload: false

------ Round 1 ----------------------------------
q1	17534	4461	4372	4372
q2	2046	152	156	152
q3	10256	1917	1951	1917
q4	10088	1286	1334	1286
q5	8457	3983	3980	3980
q6	219	127	122	122
q7	2059	1575	1600	1575
q8	9536	2718	2728	2718
q9	14154	11296	10487	10487
q10	8616	3567	3495	3495
q11	416	241	247	241
q12	465	293	303	293
q13	18381	3988	4076	3988
q14	347	324	327	324
q15	508	457	443	443
q16	683	591	584	584
q17	1113	940	934	934
q18	7200	6845	6875	6845
q19	1700	1584	1549	1549
q20	528	315	310	310
q21	4476	4126	4138	4126
q22	488	398	414	398
Total cold run time: 119270 ms
Total hot run time: 50139 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4303	4291	4294	4291
q2	324	219	216	216
q3	4154	4172	4160	4160
q4	2744	2759	2749	2749
q5	7384	7228	7183	7183
q6	232	119	118	118
q7	3285	2870	2800	2800
q8	4363	4515	4499	4499
q9	17097	16945	16989	16945
q10	4252	4278	4273	4273
q11	761	709	694	694
q12	1019	857	848	848
q13	6475	3729	3751	3729
q14	471	427	436	427
q15	492	466	447	447
q16	750	701	695	695
q17	3933	3822	3915	3822
q18	8706	8880	8819	8819
q19	1735	1718	1661	1661
q20	2401	2148	2088	2088
q21	8515	8580	8604	8580
q22	1045	955	958	955
Total cold run time: 84441 ms
Total hot run time: 79999 ms

@doris-robot
Copy link

doris-robot commented Jan 31, 2024

TPC-DS: Total hot run time: 238795 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862, data reload: false

query1	930	389	385	385
query2	6527	2245	2031	2031
query3	6911	200	201	200
query4	20435	18033	17989	17989
query5	19712	6255	6232	6232
query6	287	216	230	216
query7	4158	284	288	284
query8	267	257	241	241
query9	3167	2712	2643	2643
query10	406	301	300	300
query11	11363	10750	10699	10699
query12	114	78	69	69
query13	5653	647	633	633
query14	17660	13393	13272	13272
query15	399	223	232	223
query16	6440	264	261	261
query17	3197	878	852	852
query18	2251	401	400	400
query19	201	139	150	139
query20	76	76	76	76
query21	188	91	91	91
query22	5453	5024	5137	5024
query23	32548	31922	31818	31818
query24	6952	6495	6451	6451
query25	521	420	413	413
query26	528	157	158	157
query27	1887	292	291	291
query28	6107	2221	2174	2174
query29	2843	2799	2714	2714
query30	235	159	160	159
query31	900	741	732	732
query32	62	61	60	60
query33	388	242	238	238
query34	849	470	471	470
query35	1090	880	901	880
query36	1709	1373	1561	1373
query37	90	61	60	60
query38	3094	2973	2955	2955
query39	1359	1318	1303	1303
query40	206	97	105	97
query41	34	31	33	31
query42	91	91	86	86
query43	639	614	631	614
query44	1126	708	711	708
query45	243	226	226	226
query46	1241	976	960	960
query47	1865	1750	1963	1750
query48	978	690	660	660
query49	610	365	371	365
query50	854	609	588	588
query51	5606	5513	5450	5450
query52	89	71	76	71
query53	436	329	307	307
query54	2433	2237	2251	2237
query55	80	78	71	71
query56	189	188	192	188
query57	1233	1037	1131	1037
query58	203	197	195	195
query59	3485	3221	3206	3206
query60	194	202	189	189
query61	81	87	82	82
query62	798	477	514	477
query63	471	333	331	331
query64	1990	1294	1348	1294
query65	3691	3602	3617	3602
query66	813	363	371	363
query67	18388	15818	14980	14980
query68	10531	642	662	642
query69	548	343	332	332
query70	2417	1637	1866	1637
query71	380	295	316	295
query72	4398	3290	3330	3290
query73	730	331	328	328
query74	6446	5888	5977	5888
query75	4971	3554	3461	3461
query76	7018	1182	1205	1182
query77	1169	250	237	237
query78	33489	49227	51433	49227
query79	15132	630	629	629
query80	4424	377	370	370
query81	568	232	231	231
query82	1228	104	93	93
query83	325	130	124	124
query84	259	67	68	67
query85	1709	276	277	276
query86	452	412	375	375
query87	3269	3022	2972	2972
query88	7108	2321	2288	2288
query89	401	295	312	295
query90	2422	210	202	202
query91	157	113	120	113
query92	62	53	54	53
query93	5143	575	575	575
query94	1513	212	207	207
query95	1105	1066	1053	1053
query96	661	330	311	311
query97	6403	6291	6319	6291
query98	174	171	166	166
query99	3691	912	950	912
Total cold run time: 353327 ms
Total hot run time: 238795 ms

@doris-robot
Copy link

doris-robot commented Jan 31, 2024

ClickBench: Total hot run time: 30.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862, data reload: false

query1	0.02	0.03	0.02
query2	0.05	0.03	0.02
query3	0.24	0.05	0.05
query4	1.82	0.08	0.08
query5	0.53	0.52	0.51
query6	1.27	0.62	0.61
query7	0.01	0.01	0.01
query8	0.03	0.03	0.03
query9	0.54	0.48	0.49
query10	0.54	0.54	0.53
query11	0.12	0.08	0.10
query12	0.12	0.09	0.09
query13	0.62	0.62	0.62
query14	0.78	0.79	0.78
query15	0.78	0.77	0.76
query16	0.36	0.36	0.37
query17	1.03	1.01	0.98
query18	0.23	0.25	0.25
query19	1.95	1.86	1.84
query20	0.02	0.01	0.01
query21	15.48	0.62	0.56
query22	1.87	2.37	1.53
query23	17.39	0.94	0.83
query24	6.04	0.88	3.99
query25	1.53	0.12	0.10
query26	0.39	0.15	0.14
query27	0.12	0.11	0.11
query28	5.07	0.74	0.72
query29	12.68	2.31	2.16
query30	0.63	0.51	0.52
query31	2.82	0.39	0.39
query32	3.39	0.49	0.49
query33	3.09	3.05	3.05
query34	15.26	4.82	4.79
query35	4.85	4.83	4.84
query36	1.07	1.01	1.02
query37	0.05	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.02	0.01
query40	0.15	0.13	0.14
query41	0.06	0.01	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 103.09 s
Total hot run time: 30.45 s

@doris-robot
Copy link

doris-robot commented Jan 31, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@doris-robot
Copy link

doris-robot commented Jan 31, 2024

TeamCity be ut coverage result:
Function Coverage: 37.83% (8032/21232)
Line Coverage: 29.53% (65443/221590)
Region Coverage: 28.95% (33602/116075)
Branch Coverage: 24.81% (17242/69488)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862_7454258d8d618ddf3e56b9c4dc7d5cc51e6e0862/report/index.html

@xiaokang xiaokang merged commit cafe319 into apache:branch-2.0 Jan 31, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhangstar333
[function](char) change char function behaviour same with mysql (apac…
96e7ee6 
…he#30034) (apache#30628)

select char(0) = '\0';
should return true;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhangstar333 @doris-robot @xiaokang