[fix](outfile) Fix unable to export empty data #30703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
run performance |
TPC-H: Total hot run time: 37078 ms |
TPC-DS: Total hot run time: 174837 ms |
ClickBench: Total hot run time: 31.41 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
zxealous
force-pushed
the
fix-outfile-empty-data
branch
from
19545d0 to
5e0e28f
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
zxealous
changed the title
TPC-H: Total hot run time: 37046 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 181119 ms |
ClickBench: Total hot run time: 31.03 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
morningman
reviewed
Feb 4, 2024
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
LGTM, please add regression test case
be/src/io/fs/s3_file_writer.cpp
Outdated
| DCHECK(buf != nullptr); | ||
| buf->set_upload_to_remote([this](UploadFileBuffer& b) { _put_object(b); }); | ||
| } else { | ||
| // if there is no pending buffer, we need to create a empty file |
Contributor
There was a problem hiding this comment.
Suggested change
| // if there is no pending buffer, we need to create a empty file | |
| // if there is no pending buffer, we need to create an empty file |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
zxealous
force-pushed
the
fix-outfile-empty-data
branch
from
918fc88 to
bc04c05
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
zxealous
added a commit
to zxealous/doris
that referenced
this pull request
Feb 19, 2024
morningman
pushed a commit
to zxealous/doris
that referenced
this pull request
Feb 19, 2024
xiaokang
pushed a commit
that referenced
this pull request
Feb 19, 2024
kaijchen
added a commit
to kaijchen/doris
that referenced
this pull request
Feb 20, 2024
This reverts commit 99c3b5f.
Member
|
Hi @ zxealous, thank you for contributing to Apache Doris. Unfortunately, this PR caused a problem in the cloud pipeline, see #31148. |
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Feb 21, 2024
Issue Number: close apache#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Feb 21, 2024
Issue Number: close apache#30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
yiguolei
pushed a commit
that referenced
this pull request
Feb 21, 2024
…#28983 #30703 #31169 (#31213) * (feature)(cloud) Use dynamic allocator instead of static buffer pool for better elasticity. (#28983) * [fix](outfile) Fix unable to export empty data (#30703) Issue Number: close #30600 Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS. * [fix](file-writer) avoid empty file for segment writer (#31169) --------- Co-authored-by: AlexYue <yj976240184@gmail.com> Co-authored-by: zxealous <zhouchangyue@baidu.com>
Closed
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #30600
Fix unable to export empty data to hdfs / S3, this behavior is inconsistent with version 1.2.7, version 1.2.7 can export empty data to hdfs/ S3, and there will be exported files on S3/HDFS.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...