-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](orc) be crash while read orc with mismatch types #30738 #30747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
TPC-H: Total hot run time: 50061 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 233477 ms |
ClickBench: Total hot run time: 31.37 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
@cambyzju I think we should first push the PR to master branch and then pick to other branch. Then we will not miss any bugs that is fixed in lower version. |
@yiguolei master already change to dynamic_cast, and remove down_cast for performance reason. (#23068) And the pr marked dev/2.0.3-merged, but it seems not merged in branch-2.0. |
Proposed changes
cherry-pick #30738
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...