Skip to content

[fix](function) incorrect result of 'equal_for_null' #30990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 1 commit into from
Feb 16, 2024
Merged

[fix](function) incorrect result of 'equal_for_null' #30990

HappenLee merged 1 commit into from
Feb 16, 2024

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Feb 8, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mrhhsg
Copy link
Member Author

mrhhsg commented Feb 8, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

TeamCity be ut coverage result:
Function Coverage: 35.83% (8555/23874)
Line Coverage: 27.78% (69462/250036)
Region Coverage: 26.92% (36040/133892)
Branch Coverage: 23.70% (18425/77756)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c92a1e295451c3159ee510a37f77bcec4437a8fb_c92a1e295451c3159ee510a37f77bcec4437a8fb/report/index.html

@mrhhsg
Copy link
Member Author

mrhhsg commented Feb 8, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

TPC-H: Total hot run time: 41290 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 414c95a58b32fd9f7c349050729cc64c6f2ff922, data reload: false

------ Round 1 ----------------------------------
q1	17663	4996	4853	4853
q2	2068	146	136	136
q3	10575	1052	1009	1009
q4	4658	984	981	981
q5	7742	3188	3287	3188
q6	198	134	130	130
q7	1275	785	764	764
q8	9505	2086	2075	2075
q9	7582	6673	6654	6654
q10	8304	2661	2626	2626
q11	421	210	208	208
q12	754	327	330	327
q13	17981	3649	3682	3649
q14	295	266	255	255
q15	626	510	548	510
q16	471	404	408	404
q17	930	862	853	853
q18	7527	6595	6676	6595
q19	1572	1498	1492	1492
q20	648	364	335	335
q21	6625	3903	3958	3903
q22	855	343	348	343
Total cold run time: 108275 ms
Total hot run time: 41290 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4810	4876	4826	4826
q2	300	180	181	180
q3	3577	3562	3553	3553
q4	2556	2526	2512	2512
q5	5768	5711	5769	5711
q6	210	126	126	126
q7	2248	1655	1633	1633
q8	2992	3096	3079	3079
q9	8663	8698	8662	8662
q10	6767	4237	4224	4224
q11	531	389	385	385
q12	755	552	540	540
q13	5224	3449	3447	3447
q14	264	241	242	241
q15	582	510	499	499
q16	482	426	480	426
q17	1684	1618	1616	1616
q18	8313	7619	7731	7619
q19	1648	1634	1642	1634
q20	2106	1822	1838	1822
q21	6523	6229	6186	6186
q22	571	502	497	497
Total cold run time: 66574 ms
Total hot run time: 59418 ms

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

TPC-DS: Total hot run time: 180449 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 414c95a58b32fd9f7c349050729cc64c6f2ff922, data reload: false

query1	938	351	352	351
query2	6533	1712	1687	1687
query3	6703	226	212	212
query4	24520	22490	22524	22490
query5	4280	381	384	381
query6	253	181	187	181
query7	4604	300	293	293
query8	240	205	199	199
query9	8421	2745	2765	2745
query10	409	218	235	218
query11	16237	15672	15561	15561
query12	132	89	85	85
query13	1702	420	415	415
query14	9073	7761	7785	7761
query15	210	185	184	184
query16	7498	255	251	251
query17	1411	563	535	535
query18	1983	285	265	265
query19	195	148	155	148
query20	87	83	82	82
query21	182	127	122	122
query22	5067	4767	4821	4767
query23	32546	31471	31470	31470
query24	12654	3418	3335	3335
query25	644	362	359	359
query26	1871	149	163	149
query27	3065	322	322	322
query28	6543	1830	1818	1818
query29	1137	616	613	613
query30	283	135	147	135
query31	971	755	759	755
query32	97	58	56	56
query33	737	238	234	234
query34	1069	491	503	491
query35	959	840	818	818
query36	1051	950	902	902
query37	170	62	65	62
query38	3400	3300	3261	3261
query39	1368	1326	1300	1300
query40	283	104	105	104
query41	35	34	34	34
query42	106	97	99	97
query43	470	457	453	453
query44	1056	678	697	678
query45	203	186	180	180
query46	1054	769	770	769
query47	1684	1583	1611	1583
query48	428	346	340	340
query49	1230	308	298	298
query50	783	376	367	367
query51	5275	5181	5258	5181
query52	112	96	92	92
query53	393	294	297	294
query54	296	224	229	224
query55	86	82	80	80
query56	218	216	201	201
query57	1026	977	923	923
query58	216	197	204	197
query59	2272	2103	2081	2081
query60	246	231	217	217
query61	84	81	81	81
query62	602	393	375	375
query63	335	278	283	278
query64	6348	3031	3151	3031
query65	3296	3262	3228	3228
query66	1325	329	321	321
query67	14708	14378	14414	14378
query68	5156	582	566	566
query69	527	354	358	354
query70	1276	1187	1282	1187
query71	439	251	267	251
query72	6418	2794	2587	2587
query73	697	312	315	312
query74	7148	6745	6677	6677
query75	3243	2560	2529	2529
query76	3273	1111	1203	1111
query77	354	248	235	235
query78	9489	8881	8775	8775
query79	959	525	502	502
query80	512	349	339	339
query81	431	204	207	204
query82	161	84	90	84
query83	143	124	123	123
query84	230	78	76	76
query85	1026	338	334	334
query86	298	288	318	288
query87	3693	3409	3418	3409
query88	2716	2277	2266	2266
query89	427	351	354	351
query90	1952	162	167	162
query91	156	128	128	128
query92	56	49	50	49
query93	1007	496	501	496
query94	1112	183	178	178
query95	8812	8479	364	364
query96	572	266	270	266
query97	4470	4238	4268	4238
query98	216	206	190	190
query99	1106	720	729	720
Total cold run time: 281488 ms
Total hot run time: 180449 ms

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

ClickBench: Total hot run time: 31.21 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 414c95a58b32fd9f7c349050729cc64c6f2ff922, data reload: false

query1	0.03	0.03	0.02
query2	0.06	0.02	0.02
query3	0.23	0.07	0.07
query4	1.64	0.09	0.09
query5	0.49	0.48	0.49
query6	1.38	0.61	0.61
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.55	0.46	0.46
query10	0.49	0.48	0.49
query11	0.12	0.09	0.09
query12	0.12	0.10	0.11
query13	0.59	0.60	0.58
query14	0.76	0.79	0.78
query15	0.83	0.80	0.79
query16	0.34	0.33	0.33
query17	0.89	0.91	0.90
query18	0.18	0.18	0.18
query19	1.79	1.68	1.64
query20	0.01	0.02	0.02
query21	15.39	0.64	0.59
query22	2.63	3.77	2.64
query23	17.39	1.06	0.98
query24	1.99	0.78	0.38
query25	0.62	0.06	0.06
query26	0.15	0.14	0.13
query27	0.05	0.06	0.06
query28	11.85	0.83	0.83
query29	12.58	3.29	3.27
query30	0.54	0.47	0.48
query31	2.77	0.35	0.37
query32	3.35	0.47	0.47
query33	3.11	3.14	3.17
query34	15.35	4.46	4.49
query35	4.51	4.49	4.47
query36	1.08	0.94	0.95
query37	0.07	0.05	0.05
query38	0.03	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.02	0.01	0.02
query43	0.02	0.02	0.02
Total cold run time: 104.33 s
Total hot run time: 31.21 s

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 414c95a58b32fd9f7c349050729cc64c6f2ff922 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.3 seconds inserted 10000000 Rows, about 699K ops/s

@doris-robot
Copy link

doris-robot commented Feb 8, 2024

TeamCity be ut coverage result:
Function Coverage: 35.85% (8555/23866)
Line Coverage: 27.78% (69458/249985)
Region Coverage: 26.92% (36040/133860)
Branch Coverage: 23.70% (18426/77734)
Coverage Report: http://coverage.selectdb-in.cc/coverage/414c95a58b32fd9f7c349050729cc64c6f2ff922_414c95a58b32fd9f7c349050729cc64c6f2ff922/report/index.html

@wm1581066 wm1581066 added the p0_w label Feb 9, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 14, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 14, 2024

PR approved by anyone and no changes requested.

HappenLee
HappenLee approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit dfadf41 into apache:master Feb 16, 2024
@mrhhsg mrhhsg deleted the fix_equal_null branch February 17, 2024 23:56
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Feb 18, 2024
@mrhhsg
[fix](function) incorrect result of 'equal_for_null' (apache#30990)
3b4ffe3
@mrhhsg mrhhsg mentioned this pull request Feb 18, 2024
Merged
yiguolei pushed a commit that referenced this pull request Feb 18, 2024
@mrhhsg
[fix](function) incorrect result of 'equal_for_null' (#30990) (#31036)
61a5827
yiguolei pushed a commit that referenced this pull request Feb 18, 2024
@mrhhsg @Doris-Extras
[fix](function) incorrect result of 'equal_for_null' (#30990)
acdc957
mymeiyi pushed a commit to mymeiyi/doris that referenced this pull request Feb 19, 2024
@mrhhsg @mymeiyi
[fix](function) incorrect result of 'equal_for_null' (apache#30990)
cb152d9
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@mrhhsg
[fix](function) incorrect result of 'equal_for_null' (apache#30990) (a…
a4f9d96 
…pache#31036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.5-merged p0_w reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mrhhsg @doris-robot @yiguolei @HappenLee @wm1581066