[enhancement](function) change some function nullable mode #30991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Contributor
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| size_t get_number_of_arguments() const override { return 1; } | ||
|
|
||
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { |
Contributor
There was a problem hiding this comment.
warning: method 'get_return_type_impl' can be made static [readability-convert-member-functions-to-static]
Suggested change
| DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { | |
| static DataTypePtr get_return_type_impl(const DataTypes& arguments) override { |
Comment on lines
901
to
902
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | ||
| size_t result, size_t input_rows_count) const override { |
Contributor
There was a problem hiding this comment.
warning: method 'execute_impl' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | |
| size_t result, size_t input_rows_count) const override { | |
| static Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, | |
| size_t result, size_t input_rows_count) override { |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41452 ms |
TPC-DS: Total hot run time: 179995 ms |
ClickBench: Total hot run time: 31.35 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41420 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 180865 ms |
ClickBench: Total hot run time: 30.22 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
zclllyybb
reviewed
Feb 8, 2024
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41638 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 180932 ms |
ClickBench: Total hot run time: 31.6 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
zclllyybb
requested changes
Feb 9, 2024
Contributor
zclllyybb
left a comment
zclllyybb
left a comment
There was a problem hiding this comment.
For those change of functions' behaviour but not signature, you should apply them for both old and new version. For the functions which didn't change their signature, we don't need a old version then.
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41145 ms |
TPC-DS: Total hot run time: 180505 ms |
ClickBench: Total hot run time: 30.67 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
zclllyybb
reviewed
Feb 17, 2024
Contributor
There was a problem hiding this comment.
can u confirm this file's content? seems unrecognizable in github. not sure if it's right
Contributor
|
If you changed some SQL results. please show some examples in PR's "Proposed changes" about their result before/now. |
Contributor
Author
Okay, it's added now. |
zclllyybb
approved these changes
Feb 18, 2024
Contributor
zclllyybb
left a comment
zclllyybb
left a comment
There was a problem hiding this comment.
LGTM, the issue could be closed after this merged.
Contributor
|
PR approved by anyone and no changes requested. |
BiteTheDDDDt
approved these changes
Feb 18, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
Feb 18, 2024
change some function nullable mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #27435
change some function nullable mode, and change function unhex ,to_base64, from_base64,will return empty string when input empty string
before:
now:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...