Skip to content

[fix](nereids)disable PushdownJoinOtherCondition rule for mark join #31086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 1 commit into from
Feb 19, 2024
Merged

[fix](nereids)disable PushdownJoinOtherCondition rule for mark join #31086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...core/src/main/java/org/apache/doris/nereids/rules/rewrite/PushdownJoinOtherCondition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ public Rule build() {
return logicalJoin()
// TODO: we may need another rule to handle on true or on false condition
.when(join -> !join.getOtherJoinConjuncts().isEmpty() && !(join.getOtherJoinConjuncts().size() == 1
&& join.getOtherJoinConjuncts().get(0) instanceof BooleanLiteral))
&& join.getOtherJoinConjuncts().get(0) instanceof BooleanLiteral)
&& !join.isMarkJoin())
.then(join -> {
List<Expression> otherJoinConjuncts = join.getOtherJoinConjuncts();
List<Expression> remainingOther = Lists.newArrayList();
Expand Down