-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](index compaction) Only do index compaction for dup_keys and unique_keys with mow enabled #31136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…que_keys with mow enabled
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 50018 ms |
TPC-DS: Total hot run time: 244655 ms |
ClickBench: Total hot run time: 31.26 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
…que_keys with mow enabled (apache#31136)
Proposed changes
The fix in #31102 can lead to index files loss.
Add a restriction to
skip_inverted_indexbuild process to only allow dup_keys and unique_keys with mow enabled to do index compaction.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...