[Improve](TabletSchemaCache) reduce duplicated memory consumption for column name and column path #31141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
Member
Author
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
|
|
||
| Status RowCursor::init(const std::vector<TabletColumn>& schema) { | ||
| Status RowCursor::init(const std::vector<TabletColumnPtr>& schema) { |
Contributor
There was a problem hiding this comment.
warning: method 'init' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status RowCursor::init(const std::vector<TabletColumnPtr>& schema) { | |
| static Status RowCursor::init(const std::vector<TabletColumnPtr>& schema) { |
| } | ||
|
|
||
| Status RowCursor::init(const std::vector<TabletColumn>& schema, size_t column_count) { | ||
| Status RowCursor::init(const std::vector<TabletColumnPtr>& schema, size_t column_count) { |
Contributor
There was a problem hiding this comment.
warning: method 'init' can be made static [readability-convert-member-functions-to-static]
Suggested change
| Status RowCursor::init(const std::vector<TabletColumnPtr>& schema, size_t column_count) { | |
| static Status RowCursor::init(const std::vector<TabletColumnPtr>& schema, size_t column_count) { |
TPC-H: Total hot run time: 41543 ms |
TPC-DS: Total hot run time: 177764 ms |
ClickBench: Total hot run time: 31.34 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Member
Author
|
run buildall |
| #include <memory> | ||
| #include <string> | ||
|
|
||
| #include "olap/olap_common.h" |
Contributor
There was a problem hiding this comment.
warning: 'olap/olap_common.h' file not found [clang-diagnostic-error]
#include "olap/olap_common.h"
^
|
TeamCity be ut coverage result: |
xiaokang
changed the title
xiaokang
reviewed
Feb 27, 2024
be/src/olap/tablet_schema.h
Outdated
| TabletColumn& mutable_column_by_uid(int32_t col_unique_id); | ||
| const std::vector<TabletColumn>& columns() const; | ||
| std::vector<TabletColumn>& mutable_columns(); | ||
| void relace_column(size_t pos, TabletColumn new_col); |
… column name and column path Both could be reference to related field in TabletColumn.And use shared_ptr for TabletColumn in TabletSchema for later memory reuse
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 37815 ms |
TPC-DS: Total hot run time: 178474 ms |
ClickBench: Total hot run time: 30.52 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
qidaye
approved these changes
Mar 7, 2024
Member
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Member
Author
|
run cloud_p0 |
Member
Author
|
run buildall |
|
TeamCity be ut coverage result: |
yiguolei
pushed a commit
that referenced
this pull request
Mar 9, 2024
… column name and column path (#31141) Both could be reference to related field in TabletColumn.And use shared_ptr for TabletColumn in TabletSchema for later memory reuse
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… column name and column path
Both could be reference to related field in TabletColumn.And use shared_ptr for TabletColumn in TabletSchema for later memory reuse
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...