Skip to content

[fix](datetime) fix datetime round on BE #31205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 3 commits into from
Feb 21, 2024
Merged

[fix](datetime) fix datetime round on BE #31205

yiguolei merged 3 commits into from
Feb 21, 2024

Conversation

@zhiqiang-hhhh
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh commented Feb 21, 2024 

with tmp as (
            select CONCAT(
                YEAR('2024-02-06 03:37:07.157'), '-', 
                LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
                LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
                LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
            AS generated_string)
            select generated_string, cast(generated_string as DateTime(6)) from tmp

before (incorrect round)

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456              |
+-------------------------------+-----------------------------------------+

after (round up, keep consistent with mysql):

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457              |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)

same work with #30744 but implemented on BE

@doris-robot
Copy link

doris-robot commented Feb 21, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@zhiqiang-hhhh
Copy link
Contributor Author

zhiqiang-hhhh commented Feb 21, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024

clang-tidy review says "All clean, LGTM! 👍"

@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Feb 21, 2024
Closed
zclllyybb
zclllyybb approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Feb 21, 2024

TPC-H: Total hot run time: 41273 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit afd0540df96301fccc570198fbd103bbdea249f7, data reload: false

------ Round 1 ----------------------------------
q1	17622	4962	4836	4836
q2	2055	138	133	133
q3	10669	1008	988	988
q4	4774	935	952	935
q5	7726	3248	3256	3248
q6	193	132	133	132
q7	1244	772	772	772
q8	9394	2071	2069	2069
q9	7954	6708	6648	6648
q10	8360	2634	2621	2621
q11	432	205	196	196
q12	1109	320	348	320
q13	18052	3634	3642	3634
q14	289	261	254	254
q15	619	501	509	501
q16	521	408	418	408
q17	936	873	833	833
q18	7136	6624	6661	6624
q19	1702	1495	1655	1495
q20	567	337	347	337
q21	6154	3971	3953	3953
q22	388	351	336	336
Total cold run time: 107896 ms
Total hot run time: 41273 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4876	4811	4811	4811
q2	294	182	181	181
q3	3562	3555	3562	3555
q4	2512	2508	2505	2505
q5	5733	5702	5716	5702
q6	206	129	122	122
q7	2228	1638	1632	1632
q8	3006	3071	3094	3071
q9	8629	8695	8667	8667
q10	4130	4198	4217	4198
q11	507	380	352	352
q12	757	554	533	533
q13	4178	3371	3387	3371
q14	264	224	242	224
q15	580	510	501	501
q16	491	432	441	432
q17	1669	1574	1590	1574
q18	8359	7704	7722	7704
q19	1629	1633	1629	1629
q20	2132	1820	1825	1820
q21	6505	6092	6064	6064
q22	558	492	491	491
Total cold run time: 62805 ms
Total hot run time: 59139 ms

@doris-robot
Copy link

doris-robot commented Feb 21, 2024

TeamCity be ut coverage result:
Function Coverage: 35.72% (8558/23959)
Line Coverage: 27.60% (69414/251541)
Region Coverage: 26.73% (36016/134746)
Branch Coverage: 23.55% (18422/78238)
Coverage Report: http://coverage.selectdb-in.cc/coverage/afd0540df96301fccc570198fbd103bbdea249f7_afd0540df96301fccc570198fbd103bbdea249f7/report/index.html

@yiguolei yiguolei merged commit 989c634 into apache:master Feb 21, 2024
@yiguolei yiguolei added the usercase Important user case type label label Feb 21, 2024
@zhiqiang-hhhh zhiqiang-hhhh deleted the opt-datetime-round-be branch February 21, 2024 09:48
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Feb 21, 2024
@zhiqiang-hhhh
[fix](datetime) fix datetime round on BE (apache#31205)
31dad31 
with tmp as (
            select CONCAT(
                YEAR('2024-02-06 03:37:07.157'), '-', 
                LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
                LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
                LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
            AS generated_string)
            select generated_string, cast(generated_string as DateTime(6)) from tmp
before (incorrect round)

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456              |
+-------------------------------+-----------------------------------------+
after (round up, keep consistent with mysql):

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457              |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)
same work with apache#30744 but implemented on BE
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Feb 21, 2024
Merged
yiguolei pushed a commit that referenced this pull request Feb 21, 2024
@zhiqiang-hhhh @Doris-Extras
[fix](datetime) fix datetime round on BE (#31205)
49dd411 
with tmp as (
            select CONCAT(
                YEAR('2024-02-06 03:37:07.157'), '-', 
                LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
                LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
                LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
            AS generated_string)
            select generated_string, cast(generated_string as DateTime(6)) from tmp
before (incorrect round)

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456              |
+-------------------------------+-----------------------------------------+
after (round up, keep consistent with mysql):

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457              |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)
same work with #30744 but implemented on BE
yiguolei pushed a commit that referenced this pull request Feb 21, 2024
@zhiqiang-hhhh
[fix](datetime) fix datetime round on BE (#31205) (#31229)
37239d8 
with tmp as (
            select CONCAT(
                YEAR('2024-02-06 03:37:07.157'), '-', 
                LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
                LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
                LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
            AS generated_string)
            select generated_string, cast(generated_string as DateTime(6)) from tmp
before (incorrect round)

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456              |
+-------------------------------+-----------------------------------------+
after (round up, keep consistent with mysql):

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457              |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)
same work with #30744 but implemented on BE
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Mar 13, 2024
Merged
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@zhiqiang-hhhh
[fix](datetime) fix datetime round on BE (apache#31205) (apache#31229)
2b6e919 
with tmp as (
            select CONCAT(
                YEAR('2024-02-06 03:37:07.157'), '-', 
                LPAD(MONTH('2024-02-06 03:37:07.157'), 2, '0'), '-',
                LPAD(DAY('2024-02-06 03:37:07.157'), 2, '0'), ' ',
                LPAD(HOUR('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(MINUTE('2024-02-06 03:37:07.157'), 2, '0'), ':',
                LPAD(SECOND('2024-02-06 03:37:07.157'), 2, '0'), '.', "123456789" )
            AS generated_string)
            select generated_string, cast(generated_string as DateTime(6)) from tmp
before (incorrect round)

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123456              |
+-------------------------------+-----------------------------------------+
after (round up, keep consistent with mysql):

+-------------------------------+-----------------------------------------+
| generated_string              | cast(generated_string as DATETIMEV2(6)) |
+-------------------------------+-----------------------------------------+
| 2024-02-06 03:37:07.123456789 | 2024-02-06 03:37:07.123457              |
+-------------------------------+-----------------------------------------+
1 row in set (0.03 sec)
same work with apache#30744 but implemented on BE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhiqiang-hhhh @doris-robot @yiguolei @zclllyybb