Skip to content

[improvement](binlog)Support inverted index in CCR #31743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 5 commits into from
Mar 11, 2024
Merged

[improvement](binlog)Support inverted index in CCR #31743

xiaokang merged 5 commits into from
Mar 11, 2024

Conversation

@qidaye
Copy link
Contributor

@qidaye qidaye commented Mar 4, 2024

Support inverted index in several occasions:

  1. Creating binlog files
  2. Downloading binlog files
  3. During engine clone tasks
  4. Binlog gc

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@luennng
[improvement](binlog)Support inverted index in CCR
15867fe 
Support inverted index in several occasions:
1. Creating binlog files
2. Downloading binlog files
3. During engine clone tasks
4. Binlog gc
@doris-robot
Copy link

doris-robot commented Mar 4, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

dataroaring commented Mar 4, 2024

please add cases.

@qidaye
Copy link
Contributor Author

qidaye commented Mar 4, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 4, 2024

TeamCity be ut coverage result:
Function Coverage: 35.42% (8554/24152)
Line Coverage: 27.18% (69414/255410)
Region Coverage: 26.40% (36016/136425)
Branch Coverage: 23.24% (18397/79162)
Coverage Report: http://coverage.selectdb-in.cc/coverage/15867fe73cc46db64d8f9203c21b3af684f2a125_15867fe73cc46db64d8f9203c21b3af684f2a125/report/index.html

xiaokang
xiaokang reviewed Mar 5, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@qidaye qidaye requested a review from xiaokang March 5, 2024 12:03
@qidaye
Copy link
Contributor Author

qidaye commented Mar 5, 2024

run buildall

1 similar comment
@qidaye
Copy link
Contributor Author

qidaye commented Mar 5, 2024

run buildall

xiaokang
xiaokang previously approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Mar 5, 2024

TeamCity be ut coverage result:
Function Coverage: 35.42% (8557/24157)
Line Coverage: 27.16% (69436/255661)
Region Coverage: 26.39% (36033/136553)
Branch Coverage: 23.22% (18410/79286)
Coverage Report: http://coverage.selectdb-in.cc/coverage/28d4c4424c55340de3401db7038f309f48d2bf35_28d4c4424c55340de3401db7038f309f48d2bf35/report/index.html

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@qidaye
Copy link
Contributor Author

qidaye commented Mar 7, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@qidaye
Copy link
Contributor Author

qidaye commented Mar 7, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Mar 7, 2024

TeamCity be ut coverage result:
Function Coverage: 35.39% (8561/24189)
Line Coverage: 27.13% (69505/256189)
Region Coverage: 26.36% (36066/136795)
Branch Coverage: 23.20% (18430/79446)
Coverage Report: http://coverage.selectdb-in.cc/coverage/be355638d4f6e226ffc0fe429b545831d07d1ae6_be355638d4f6e226ffc0fe429b545831d07d1ae6/report/index.html

JackDrogon
JackDrogon approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@JackDrogon JackDrogon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaokang
xiaokang approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2024

PR approved by at least one committer and no changes requested.

@xiaokang xiaokang merged commit 917e425 into apache:master Mar 11, 2024
@qidaye qidaye deleted the ccr_inverted_index branch March 11, 2024 03:35
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Mar 12, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (apache#31743)
0a81868
@qidaye qidaye mentioned this pull request Mar 12, 2024
Merged
yiguolei pushed a commit that referenced this pull request Mar 12, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (#31743) (#32101)
5f125bb
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jun 12, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (apache#31743)
73c6fdd
@qidaye qidaye mentioned this pull request Jun 12, 2024
Merged
qidaye added a commit to qidaye/incubator-doris that referenced this pull request Jun 13, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (apache#31743)
9d4d505
xiaokang pushed a commit that referenced this pull request Jun 16, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (#31743) (#36203)
09b56d5
@xiaokang xiaokang mentioned this pull request Jun 23, 2024
Closed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@qidaye
[improvement](binlog)Support inverted index in CCR (apache#31743) (ap…
d8cd2c9 
…ache#36203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiaokang xiaokang xiaokang approved these changes

+1 more reviewer

@JackDrogon JackDrogon JackDrogon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.12-merged dev/2.1.0 reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@qidaye @doris-robot @dataroaring @xiaokang @JackDrogon @yiguolei @luennng