Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 7, 2024

Proposed changes

The parameter of offset was not used.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 7, 2024

run buildall

@wm1581066 wm1581066 added dev/2.0.x usercase Important user case type label labels Mar 7, 2024
@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 7, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.40% (8560/24184)
Line Coverage: 27.15% (69509/256026)
Region Coverage: 26.38% (36066/136725)
Branch Coverage: 23.21% (18428/79402)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e04f4b4df24d3c9179598f6f5455b99e7d96fb42_e04f4b4df24d3c9179598f6f5455b99e7d96fb42/report/index.html

Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 6692447 into apache:master Mar 7, 2024
@mrhhsg mrhhsg deleted the fix_map_agg branch March 8, 2024 02:23
@yiguolei yiguolei mentioned this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.6-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants