Skip to content

[opt](routine-load) optimize allocate task to be algorithm for load balance #32021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liaoxin01 merged 1 commit into from
Mar 20, 2024
Merged

[opt](routine-load) optimize allocate task to be algorithm for load balance #32021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ public long getAvailableBeForTask(long jobId, long previousBeId) throws LoadExce
try {
Map<Long, Integer> beIdToConcurrentTasks = getBeCurrentTasksNumMap();

// 1. Find if the given BE id has available slots
// 1. Find if the given BE id has more than half of available slots
if (previousBeId != -1L && availableBeIds.contains(previousBeId)) {
// get the previousBackend info
Backend previousBackend = Env.getCurrentSystemInfo().getBackend(previousBeId);
Expand All @@ -499,7 +499,7 @@ public long getAvailableBeForTask(long jobId, long previousBeId) throws LoadExce
} else {
idleTaskNum = beIdToMaxConcurrentTasks.get(previousBeId);
}
if (idleTaskNum > 0) {
if (idleTaskNum > (Config.max_routine_load_task_num_per_be >> 1)) {
return previousBeId;
}
}
Expand Down
3 changes: 2 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadTaskScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ private void submitTask(long beId, TRoutineLoadTask tTask) throws LoadException
}

// try to allocate a task to BE which has idle slot.
// 1. First is to check if the previous allocated BE is available. If yes, allocate task to previous BE.
// 1. First is to check if the previous allocated BE has more than half of available slots.
// If yes, allocate task to previous BE.
// 2. If not, try to find a better one with most idle slots.
// return true if allocate successfully. return false if failed.
// throw exception if unrecoverable errors happen.
Expand Down