Skip to content

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented Mar 11, 2024

Proposed changes

Issue Number: close #xxx

Formerly the cooldown meta write task would continue doing no matter the tablet is dropped or not. It serves well under most circumstances, while it would end up with endless retrying if the corresponding storage policy is dropped neither. Which means the logic would be as follows:

1. Try to write cooldown meta
2. get the fs using the storage policy
3. can't not get the storage policy since it's dropped
4. repeat 1

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@ByteYue
Copy link
Contributor Author

ByteYue commented Mar 11, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 34.98% (8556/24459)
Line Coverage: 26.82% (69535/259263)
Region Coverage: 26.07% (36087/138417)
Branch Coverage: 23.04% (18446/80070)
Coverage Report: http://coverage.selectdb-in.cc/coverage/40628c4c962337a2ae02347e68c6296049b037e2_40628c4c962337a2ae02347e68c6296049b037e2/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38084 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40628c4c962337a2ae02347e68c6296049b037e2, data reload: false

------ Round 1 ----------------------------------
q1	17621	4092	4035	4035
q2	2027	151	140	140
q3	10571	951	956	951
q4	4665	939	941	939
q5	7603	2839	3010	2839
q6	182	125	130	125
q7	1309	847	821	821
q8	9499	2042	2073	2042
q9	7302	6491	6560	6491
q10	8264	2576	2560	2560
q11	426	225	206	206
q12	750	321	312	312
q13	17987	3003	2987	2987
q14	273	257	252	252
q15	505	465	462	462
q16	479	403	392	392
q17	958	874	835	835
q18	6775	5933	5978	5933
q19	1560	1537	1525	1525
q20	556	283	278	278
q21	7582	3715	3663	3663
q22	821	299	296	296
Total cold run time: 107715 ms
Total hot run time: 38084 ms

----- Round 2, with runtime_filter_mode=off -----
q1	3992	3992	4000	3992
q2	327	235	231	231
q3	2995	2908	2947	2908
q4	1826	1822	1812	1812
q5	5226	5283	5302	5283
q6	202	116	123	116
q7	2256	1841	1848	1841
q8	3215	3271	3266	3266
q9	8568	8609	8552	8552
q10	6165	3755	3703	3703
q11	545	466	436	436
q12	712	554	533	533
q13	10602	2866	2839	2839
q14	278	246	253	246
q15	488	447	457	447
q16	446	421	410	410
q17	1703	1674	1658	1658
q18	8122	7535	7318	7318
q19	1767	1606	1609	1606
q20	1912	1716	1678	1678
q21	4981	4885	4979	4885
q22	518	419	449	419
Total cold run time: 66846 ms
Total hot run time: 54179 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186674 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 40628c4c962337a2ae02347e68c6296049b037e2, data reload: false

query1	919	359	355	355
query2	7414	2084	1940	1940
query3	6705	214	207	207
query4	24364	20912	20866	20866
query5	4307	5500	739	739
query6	272	185	185	185
query7	4620	318	301	301
query8	234	164	166	164
query9	8447	2319	2272	2272
query10	461	241	252	241
query11	14937	14587	14527	14527
query12	132	92	87	87
query13	1639	429	438	429
query14	11030	9960	9655	9655
query15	262	208	197	197
query16	7832	276	279	276
query17	1882	583	549	549
query18	2040	291	273	273
query19	187	159	160	159
query20	99	85	88	85
query21	198	125	132	125
query22	4681	4534	4508	4508
query23	31816	30935	30818	30818
query24	9828	3031	3061	3031
query25	630	370	368	368
query26	1285	164	171	164
query27	2440	361	356	356
query28	6252	1837	1831	1831
query29	1024	584	586	584
query30	307	153	152	152
query31	917	720	744	720
query32	105	64	60	60
query33	749	270	267	267
query34	1020	458	470	458
query35	868	618	625	618
query36	900	795	797	795
query37	142	71	72	71
query38	3249	3205	3172	3172
query39	1433	1375	1387	1375
query40	206	111	115	111
query41	80	62	61	61
query42	111	103	102	102
query43	476	411	415	411
query44	1052	695	705	695
query45	267	257	257	257
query46	1047	797	770	770
query47	1631	1597	1594	1594
query48	428	368	346	346
query49	1127	344	321	321
query50	781	374	373	373
query51	6771	6607	6573	6573
query52	108	91	98	91
query53	355	285	283	283
query54	282	236	242	236
query55	92	85	80	80
query56	239	227	216	216
query57	1079	1000	992	992
query58	240	205	218	205
query59	2583	2338	2344	2338
query60	252	241	266	241
query61	139	95	105	95
query62	644	405	416	405
query63	301	281	275	275
query64	5249	3346	3091	3091
query65	3014	2982	2977	2977
query66	832	327	327	327
query67	14488	14445	14781	14445
query68	6031	557	557	557
query69	599	398	398	398
query70	1196	1108	1107	1107
query71	508	284	284	284
query72	6552	2779	2599	2599
query73	783	317	321	317
query74	6868	6609	6500	6500
query75	9175	8125	8152	8125
query76	4254	1111	1163	1111
query77	638	270	290	270
query78	10275	9533	9576	9533
query79	9808	528	533	528
query80	1589	411	407	407
query81	503	215	213	213
query82	761	198	195	195
query83	221	149	144	144
query84	305	83	84	83
query85	1496	326	316	316
query86	410	286	290	286
query87	3461	3245	3279	3245
query88	3883	2347	2336	2336
query89	514	368	363	363
query90	2043	185	172	172
query91	160	127	128	127
query92	58	54	48	48
query93	6957	543	518	518
query94	1167	186	184	184
query95	449	338	344	338
query96	598	259	264	259
query97	4412	4258	4259	4258
query98	238	204	205	204
query99	1172	758	759	758
Total cold run time: 296585 ms
Total hot run time: 186674 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.21 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 40628c4c962337a2ae02347e68c6296049b037e2, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.66	0.10	0.10
query5	0.52	0.50	0.49
query6	1.18	0.68	0.67
query7	0.02	0.02	0.01
query8	0.03	0.03	0.03
query9	0.56	0.51	0.52
query10	0.57	0.56	0.56
query11	0.13	0.10	0.10
query12	0.12	0.10	0.11
query13	0.57	0.58	0.58
query14	0.72	0.77	0.77
query15	0.84	0.80	0.82
query16	0.37	0.37	0.40
query17	0.97	1.05	0.95
query18	0.27	0.25	0.24
query19	1.84	1.67	1.70
query20	0.02	0.01	0.01
query21	15.43	0.64	0.60
query22	3.30	4.32	1.96
query23	17.65	0.97	0.96
query24	2.21	0.28	0.19
query25	0.24	0.05	0.04
query26	0.19	0.15	0.14
query27	0.03	0.03	0.04
query28	12.62	0.82	0.82
query29	12.55	3.39	3.39
query30	0.63	0.58	0.52
query31	2.79	0.35	0.34
query32	3.36	0.43	0.43
query33	2.86	2.86	2.81
query34	15.49	4.30	4.30
query35	4.29	4.31	4.29
query36	1.08	1.01	1.01
query37	0.07	0.05	0.05
query38	0.04	0.03	0.03
query39	0.02	0.02	0.01
query40	0.18	0.15	0.14
query41	0.07	0.02	0.01
query42	0.02	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.87 s
Total hot run time: 30.21 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 40628c4c962337a2ae02347e68c6296049b037e2 with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       17.4 seconds inserted 10000000 Rows, about 574K ops/s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.7-merged dev/2.1.0 reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants