-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](Cooldown) Skip cooldown if the tablet is dropped #32079
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 38084 ms |
TPC-DS: Total hot run time: 186674 ms |
ClickBench: Total hot run time: 30.21 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Proposed changes
Issue Number: close #xxx
Formerly the cooldown meta write task would continue doing no matter the tablet is dropped or not. It serves well under most circumstances, while it would end up with endless retrying if the corresponding storage policy is dropped neither. Which means the logic would be as follows:
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...