-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](function) support hll functions hll_from_base64, hll_to_base64 #32089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. |
|
run buildall |
TPC-H: Total hot run time: 36886 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 186690 ms |
ClickBench: Total hot run time: 30.54 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
docs/en/docs/sql-manual/sql-functions/hll-functions/hll-from-base64.md
Outdated
Show resolved
Hide resolved
a4efb76 to
9f87b21
Compare
|
run buildall |
TPC-H: Total hot run time: 36779 ms |
TPC-DS: Total hot run time: 187629 ms |
ClickBench: Total hot run time: 29.99 s |
42b9f75 to
93d3f58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
96710e4 to
3964185
Compare
update branch
|
run buildall |
|
TeamCity be ut coverage result: |
| doris::Slice decoded_slice(decode_buff.data(), outlen); | ||
| doris::HyperLogLog hll; | ||
| if (!hll.deserialize(decoded_slice)) { | ||
| return Status::RuntimeError( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not set NULL ? or return ERROR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw bitmap_from_base64() return error, shouldn't we keep the same?
7f9c847 to
efae565
Compare
|
run buildall |
TPC-H: Total hot run time: 38769 ms |
|
run feut |
TPC-DS: Total hot run time: 183186 ms |
ClickBench: Total hot run time: 30.22 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…ntersect functions (#560) - hll_from_base64, hll_to_base64: master pr: apache/doris#32089 - group_array_intersect: master pr: apache/doris#33265
Proposed changes
Issue Number: #31320
Support two hll functions:
Convert a base64 string(result of function hll_to_base64) into a hll.
Convert an input hll to a base64 string.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...